build: Transition from Java EE to Jakarta EE #80

skabashnyuk · 2021-08-10T13:30:42Z

What does this PR do?

The transition from Java EE to Jakarta EE
PR can be reviewed commit by commit.
TODO
Everrest CQ - https://dev.eclipse.org/ipzilla/show_bug.cgi?id=23669

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#20247

How to test this PR?

build or deploy che-server's image quay.io/skabashn/che-server:jakarta_2021_09_03_14_12_20
login as "kubeadmin" on OpenShift
Start new workspace.
Workspace should start successfully.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

dmytro-ndp · 2021-08-17T07:57:36Z

[crw-ci-test --rebuild]

dmytro-ndp · 2021-08-17T09:14:19Z

[crw-ci-test --rebuild]

che-bot · 2021-08-20T12:10:18Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

sparkoo · 2021-08-23T16:41:01Z

I can't see the error in che-server:next

che-bot · 2021-08-25T07:12:58Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

dockerfiles/che/entrypoint.sh

assembly/assembly-wsmaster-war/pom.xml

...t/java/org/eclipse/che/multiuser/machine/authentication/server/MachineTokenRegistryTest.java

metlos

I agree with @sparkoo 's comments and have some more minor things...

...er/src/main/java/org/eclipse/che/multiuser/keycloak/server/deploy/KeycloakServletModule.java

...erver/src/test/java/org/eclipse/che/multiuser/keycloak/server/KeycloakServletModuleTest.java

che-bot · 2021-09-02T14:16:54Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-09-03T06:27:30Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-09-03T09:32:25Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

skabashnyuk · 2021-09-03T09:40:27Z

[crw-ci-test --rebuild]

che-bot · 2021-09-03T10:16:39Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

skabashnyuk · 2021-09-03T10:59:05Z

[crw-ci-test --rebuild]

skabashnyuk · 2021-09-03T11:18:00Z

@sparkoo @metlos I've addressed your comments. Code tested with che7 and devworkspaces.

che-bot · 2021-09-03T11:21:52Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

skabashnyuk · 2021-09-03T11:24:53Z

[crw-ci-test --rebuild]

che-bot · 2021-09-03T12:13:10Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

sparkoo

tested with devworkspaces

che-bot · 2021-09-09T05:39:40Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

skabashnyuk · 2021-09-09T06:20:06Z

[crw-ci-test --rebuild]

che-bot · 2021-09-09T06:35:12Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-09-09T11:32:33Z

❌ E2E Happy path tests failed ❗

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

che-bot · 2021-09-09T13:08:30Z

✅ E2E Happy path tests succeed 🎉

See Details

Jenkins job
test report
logs and configs
Happy path tests DevFile
image: quay.io/crw_pr/che-server:80

Test product:

tested with Eclipse Che on K8S (minikube v1.22.0)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

skabashnyuk changed the title ~~Transition from Java EE to Jakarta EE~~ build: Transition from Java EE to Jakarta EE Aug 16, 2021

AndrienkoAleksandr mentioned this pull request Aug 19, 2021

We need reimplement auto login for swagger operations eclipse-che/che#20334

Closed

skabashnyuk force-pushed the jakarta branch 2 times, most recently from ef8960d to d327cde Compare August 20, 2021 11:16

skabashnyuk added 12 commits August 20, 2021 14:29

Upgrade swagger-ui-3.51.2

55d0f8d

Upgrade tomcat 10.0.10

2849c3f

changed only imports

7071c86

changed imports in service loader

90b2c14

changed swagger jaxrs deployment

e989521

Changed swagger annotations + basic imports

fef9b2f

Changed imports and minimal key length for jsonwebtoken

bd29e91

Restassured API changes + imports

2c6ad69

Removed trailing slash from CHE_HOME

f788457

Migrate to jakarta schema in web.xml

af97cbe

Disable tracing

4d4684f

New artifacts and maven build upgrade

cb8362a

skabashnyuk force-pushed the jakarta branch from d327cde to cb8362a Compare August 20, 2021 11:35

eclipse-che deleted a comment from che-bot Aug 20, 2021

skabashnyuk marked this pull request as ready for review August 23, 2021 07:02

Removed jackson-jaxrs-json-provider from wsmaster war

2646fb7

sparkoo reviewed Aug 25, 2021

View reviewed changes

dockerfiles/che/entrypoint.sh Show resolved Hide resolved

assembly/assembly-wsmaster-war/pom.xml Outdated Show resolved Hide resolved

...t/java/org/eclipse/che/multiuser/machine/authentication/server/MachineTokenRegistryTest.java Show resolved Hide resolved

metlos reviewed Sep 1, 2021

View reviewed changes

...er/src/main/java/org/eclipse/che/multiuser/keycloak/server/deploy/KeycloakServletModule.java Outdated Show resolved Hide resolved

...erver/src/test/java/org/eclipse/che/multiuser/keycloak/server/KeycloakServletModuleTest.java Outdated Show resolved Hide resolved

Merge remote-tracking branch 'upstream/main' into jakarta

8353474

Merge remote-tracking branch 'upstream/main' into jakarta

95086ba

Fixed KeycloakServletModuleTest and forked TracingFilter

6dd1a84

sparkoo approved these changes Sep 8, 2021

View reviewed changes

Merge remote-tracking branch 'upstream/main' into jakarta

cdf92de

Merge remote-tracking branch 'upstream/main' into jakarta

8c0b28b

Removed unused dependecies

3e55784

skabashnyuk merged commit 359ebb3 into eclipse-che:main Sep 13, 2021

skabashnyuk deleted the jakarta branch September 13, 2021 05:20

skabashnyuk added this to the 7.37 milestone Sep 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: Transition from Java EE to Jakarta EE #80

build: Transition from Java EE to Jakarta EE #80

skabashnyuk commented Aug 10, 2021 •

edited

Loading

dmytro-ndp commented Aug 17, 2021

dmytro-ndp commented Aug 17, 2021

che-bot commented Aug 20, 2021

sparkoo commented Aug 23, 2021

che-bot commented Aug 25, 2021

metlos left a comment

che-bot commented Sep 2, 2021

che-bot commented Sep 3, 2021

che-bot commented Sep 3, 2021

skabashnyuk commented Sep 3, 2021

che-bot commented Sep 3, 2021

skabashnyuk commented Sep 3, 2021

skabashnyuk commented Sep 3, 2021

che-bot commented Sep 3, 2021

skabashnyuk commented Sep 3, 2021

che-bot commented Sep 3, 2021

sparkoo left a comment

che-bot commented Sep 9, 2021

skabashnyuk commented Sep 9, 2021

che-bot commented Sep 9, 2021

che-bot commented Sep 9, 2021

che-bot commented Sep 9, 2021

build: Transition from Java EE to Jakarta EE #80

build: Transition from Java EE to Jakarta EE #80

Conversation

skabashnyuk commented Aug 10, 2021 • edited Loading

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

dmytro-ndp commented Aug 17, 2021

dmytro-ndp commented Aug 17, 2021

che-bot commented Aug 20, 2021

sparkoo commented Aug 23, 2021

che-bot commented Aug 25, 2021

metlos left a comment

Choose a reason for hiding this comment

che-bot commented Sep 2, 2021

che-bot commented Sep 3, 2021

che-bot commented Sep 3, 2021

skabashnyuk commented Sep 3, 2021

che-bot commented Sep 3, 2021

skabashnyuk commented Sep 3, 2021

skabashnyuk commented Sep 3, 2021

che-bot commented Sep 3, 2021

skabashnyuk commented Sep 3, 2021

che-bot commented Sep 3, 2021

sparkoo left a comment

Choose a reason for hiding this comment

che-bot commented Sep 9, 2021

skabashnyuk commented Sep 9, 2021

che-bot commented Sep 9, 2021

che-bot commented Sep 9, 2021

che-bot commented Sep 9, 2021

skabashnyuk commented Aug 10, 2021 •

edited

Loading