Persist cheEditor and kubernetes components when updating the devfile

[vitaliy-guliy]

Signed-off-by: Vitaliy Gulyy vgulyy@redhat.com

What does this PR do?

• Fixes updating of the devfile by a request from Che-Theia.
• Fixes setting of the plugins to the devfile form the Plugins panel.

Link with #1076

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

As the author of this Pull Request I made sure that:

• The Eclipse Contributor Agreement is valid
• Code produced is complete
• Code builds without errors
• Tests are covering the bugfix
• The repository devfile is up to date and works
• Sections What issues does this PR fix or reference and How to test this PR completed
• Relevant user documentation updated
• Relevant contributing documentation updated
• CI/CD changes implemented, documented and communicated

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

[benoitf]

I don't see why we filter out these components ?

[vitaliy-guliy]

Giving them to the client does not have any sense, as it uses devfile2.

[vitaliy-guliy]

Do you prefer to send them to the client and mark with special attribute?

[codecov]

Codecov Report

Merging #1083 (7a0c786) into master (eeb4526) will increase coverage by 1.83%.
The diff coverage is 50.35%.

@@            Coverage Diff             @@
##           master    #1083      +/-   ##
==========================================
+ Coverage   29.45%   31.28%   +1.83%     
==========================================
  Files         277      277              
  Lines        9336     9403      +67     
  Branches     1380     1407      +27     
==========================================
+ Hits         2750     2942     +192     
+ Misses       6487     6364     -123     
+ Partials       99       97       -2     

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	0.00% <ø> (ø)
...ovisioner/src/node/git-configuration-controller.ts	0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts	0.00% <0.00%> (ø)
...-che-theia-plugin-remote/src/node/plugin-remote.ts	0.00% <0.00%> (ø)
...plugin-remote/src/node/terminal-container-aware.ts	0.00% <0.00%> (ø)
...a-plugin-remote/src/node/webviews-content-aware.ts	0.00% <0.00%> (ø)
...che-theia-remote-api/src/common/devfile-service.ts	0.00% <ø> (ø)
...e-theia-remote-api/src/common/workspace-service.ts	0.00% <ø> (ø)
...er/src/node/che-server-certificate-service-impl.ts	0.00% <0.00%> (ø)
...-impl-k8s/src/node/k8s-certificate-service-impl.ts	0.00% <0.00%> (ø)
... and 28 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd3b88...7a0c786. Read the comment docs.

[che-bot]

✅ E2E Happy path tests succeed 🎉

See Details

• Jenkins job console

• logs and configs

• Happy path tests DevFile

• images:

name	link
che-theia	quay.io/crw_pr/che-theia:1083
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1083

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

• Use comment "[crw-ci-test]" to rerun happy path E2E test.
• Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

[vitaliy-guliy]

There is another approach has been merged to master #1084
Another PR for kubernetes components wil be provided within eclipse-che/che#19634