This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Handle cheEditor component in addition to chePlugin #1084
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: svor <vsvydenk@redhat.com>
svor
requested review from
azatsarynnyy,
benoitf,
RomanNikitenko and
vzhukovs
as code owners
April 20, 2021 20:45
benoitf
approved these changes
Apr 20, 2021
ericwill
approved these changes
Apr 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with the gist in the PR description and it works 🎉
9 tasks
Codecov Report
@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 29.45% 31.32% +1.86%
==========================================
Files 277 277
Lines 9336 9395 +59
Branches 1380 1404 +24
==========================================
+ Hits 2750 2943 +193
+ Misses 6487 6355 -132
+ Partials 99 97 -2
Continue to review full report at Codecov.
|
✅ E2E Happy path tests succeed 🎉 See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1)
|
9 tasks
This was referenced Apr 21, 2021
svor
added a commit
to svor/che-theia
that referenced
this pull request
Apr 22, 2021
Signed-off-by: svor <vsvydenk@redhat.com>
svor
added a commit
that referenced
this pull request
Apr 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the problem with installing plugins from Plugins view
This PR extends Florent's PR #1081
Screenshot/screencast of this PR
What issues does this PR fix or reference?
eclipse-che/che#19623
How to test this PR?
try to add this component into your devfile:
PR Checklist
As the author of this Pull Request I made sure that:
What issues does this PR fix or reference
andHow to test this PR
completedReviewers
Reviewers, please comment how you tested the PR when approving it.
Happy Path Channel
HAPPY_PATH_CHANNEL=next