Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Handle cheEditor component in addition to chePlugin #1084

Merged
merged 1 commit into from
Apr 20, 2021

Conversation

svor
Copy link
Contributor

@svor svor commented Apr 20, 2021

What does this PR do?

Fixes the problem with installing plugins from Plugins view

This PR extends Florent's PR #1081

Screenshot/screencast of this PR

screenshot-che-dogfooding apps che-dev x6e0 p1 openshiftapps com-2021 04 20-23_38_44

What issues does this PR fix or reference?

eclipse-che/che#19623

How to test this PR?

try to add this component into your devfile:

  - type: cheEditor
    reference: 'https://gist.githubusercontent.com/svor/966bff2009ceaad7d64d8d14fd040155/raw/f28318b9a4f308012171bce1590ec725ca913306/che-theia-editor.yaml'

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=next

Signed-off-by: svor <vsvydenk@redhat.com>
Copy link
Contributor

@ericwill ericwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the gist in the PR description and it works 🎉

@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #1084 (1a2abb4) into master (eeb4526) will increase coverage by 1.86%.
The diff coverage is 50.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1084      +/-   ##
==========================================
+ Coverage   29.45%   31.32%   +1.86%     
==========================================
  Files         277      277              
  Lines        9336     9395      +59     
  Branches     1380     1404      +24     
==========================================
+ Hits         2750     2943     +193     
+ Misses       6487     6355     -132     
+ Partials       99       97       -2     
Impacted Files Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx 0.00% <ø> (ø)
...ovisioner/src/node/git-configuration-controller.ts 0.00% <0.00%> (ø)
...theia-plugin-remote/src/node/plugin-remote-init.ts 0.00% <0.00%> (ø)
...-che-theia-plugin-remote/src/node/plugin-remote.ts 0.00% <0.00%> (ø)
...plugin-remote/src/node/terminal-container-aware.ts 0.00% <0.00%> (ø)
...a-plugin-remote/src/node/webviews-content-aware.ts 0.00% <0.00%> (ø)
...che-theia-remote-api/src/common/devfile-service.ts 0.00% <ø> (ø)
...e-theia-remote-api/src/common/workspace-service.ts 0.00% <ø> (ø)
...er/src/node/che-server-certificate-service-impl.ts 0.00% <0.00%> (ø)
...-impl-k8s/src/node/k8s-certificate-service-impl.ts 0.00% <0.00%> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6077388...1a2abb4. Read the comment docs.

@che-bot
Copy link
Contributor

che-bot commented Apr 20, 2021

✅ E2E Happy path tests succeed 🎉

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia quay.io/crw_pr/che-theia:1084
che-theia-endpoint-runtime-binary quay.io/crw_pr/che-theia-endpoint-runtime-binary:1084

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

  • Use comment "[crw-ci-test]" to rerun happy path E2E test.
  • Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants