Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Run Che command in selected container if container doesn't specified in configuration #274

Closed
wants to merge 1 commit into from

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Jun 11, 2019

Description

If container in which command should be run cannot be detected from config, run the command in selected container.
To reach that we need to send task modification which should be applied to persistent task configuration for only this one run and define the currently used container as a target container.

Resolves

https://github.com/eclipse/che-theia/issues/222

Depends on

eclipse-theia/theia#5312

…in configuration

Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
@@ -106,7 +108,7 @@ export class ContainersTreeDataProvider implements theia.TreeDataProvider<ITreeN
name: commandName,
tooltip: 'execute the command',
iconPath: 'fa-cogs medium-yellow',
command: { id: 'task:run', arguments: ['che', commandName] }
command: { id: 'task:run', arguments: [CHE_TASK_TYPE, commandName, this.overrideContainerName(container.name)] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello, it couldn't be another field ? looks like we're now having complex types for command

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not use dedicated method and constant.
Just inline

{
    type: 'che',
    target: {
        machineName: containerName
    }
}

@vitaliy-guliy
Copy link
Contributor

vitaliy-guliy commented Aug 20, 2019

@mmorhun could we wait until the #295 is merged and then will test the case again? I have a feeling that PR #295 will fix the problem.

@che-bot
Copy link
Contributor

che-bot commented Sep 4, 2019

E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:

@mmorhun
Copy link
Contributor Author

mmorhun commented Sep 16, 2019

Closing this because the solution idea was changed due to changes in upstream.
There is a new PR that address the issue: #440

@mmorhun mmorhun closed this Sep 16, 2019
@mmorhun mmorhun deleted the che-theia-222 branch September 16, 2019 13:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants