This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Run Che command in selected container if container doesn't specified in configuration #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in configuration Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
mmorhun
requested review from
sunix,
evidolob,
azatsarynnyy,
vitaliy-guliy,
RomanNikitenko,
olexii4 and
AndrienkoAleksandr
AndrienkoAleksandr
approved these changes
Jun 11, 2019
benoitf
reviewed
Jun 11, 2019
| @@ -106,7 +108,7 @@ export class ContainersTreeDataProvider implements theia.TreeDataProvider<ITreeN | |||
| name: commandName, | |||
| tooltip: 'execute the command', | |||
| iconPath: 'fa-cogs medium-yellow', | |||
| command: { id: 'task:run', arguments: ['che', commandName] } | |||
| command: { id: 'task:run', arguments: [CHE_TASK_TYPE, commandName, this.overrideContainerName(container.name)] } | |||
There was a problem hiding this comment.
hello, it couldn't be another field ? looks like we're now having complex types for command
There was a problem hiding this comment.
I would not use dedicated method and constant.
Just inline
{
type: 'che',
target: {
machineName: containerName
}
}
29 tasks
16 tasks
18 tasks
26 tasks
20 tasks
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
|
Closing this because the solution idea was changed due to changes in upstream. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If container in which command should be run cannot be detected from config, run the command in selected container.
To reach that we need to send task modification which should be applied to persistent task configuration for only this one run and define the currently used container as a target container.
Resolves
https://github.com/eclipse/che-theia/issues/222
Depends on
eclipse-theia/theia#5312