-
Notifications
You must be signed in to change notification settings - Fork 111
Run Che command in selected container #440
Conversation
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, why yarn lock file is totally changed ?
@benoitf because I need newer version of some Theia dependencies and I just regenerated yarn.lock file. Anyway we need to update it soon or late. WDYT? |
@mmorhun In the case when we regenerate yarn.lock file just because we need to update it soon or later - add these changes in a separate commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes using commands
section of the provided devfile.
It works well for me: the clicked command is run in the right container.
But I noticed that this implementation changes the current behavior.
Before the changes:
The list of problem matchers is displayed before running a task
After the changes:
The list of problem matchers is NOT displayed before running a task
crw-ci-test |
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
@RomanNikitenko thanks for your review. |
@mmorhun Problem matchers for tasks was added to theia project recently (about 2 weeks) and at the moment user doesn't have ability to define problem matchers for actions with type So, to be exact - yes, the PR changes the current behavior for first time running task without problem matchers from |
@slemeur please take a look |
Signed-off-by: Mykola Morhun <mmorhun@redhat.com>
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has failed:
|
crw-ci-test |
E2E Happy path tests of Eclipse Che Single User on K8S (minikube v1.1.1) has been successful:
|
Signed-off-by: Mykola Morhun mmorhun@redhat.com
What does this PR do?
In some cases it is impossible to figure out container for a command defined in Che workspace devfile. Then such a command is displayed in each container of the workspace in Workspace panel. But when a user clicks on it, Che asks the user to select container in which this command should be run. But in case of clicking on specific node of specific container it is obvious in which container this command should be run this time.
This PR addresses such case and runs the clicked command in the right container.
Example of workspace which has ambiguous commands:
devfile
Provides fix for: eclipse-che/che#13764