Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide curated list of containers to run tasks #13390

Closed
slemeur opened this issue May 22, 2019 · 8 comments
Closed

Provide curated list of containers to run tasks #13390

slemeur opened this issue May 22, 2019 · 8 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@slemeur
Copy link
Contributor

slemeur commented May 22, 2019

Description

When running a tasks, the user is asked on which container to run the tasks while he has not idea of what are all the containers (especially those for plugins).

Capture d’écran 2019-05-22 à 12 13 00

We should currate the list of containers where to execute the tasks to only the user's runtime ones and use a similar mechanism than for opening a terminal.

Capture d’écran 2019-05-22 à 12 19 34

Update: behavior should be the same when select container dialog appears.

@slemeur slemeur added kind/enhancement A feature request - must adhere to the feature request template. team/ide labels May 22, 2019
@slemeur slemeur changed the title Focused list of containers to run tasks Provide curated list of containers to run tasks May 22, 2019
@l0rd l0rd mentioned this issue May 28, 2019
@vparfonov vparfonov added the status/in-progress This issue has been taken by an engineer and is under active development. label Jun 4, 2019
@vzhukovs
Copy link
Contributor

@slemeur, we can't assign hotkey to switch display machine list, due to following flow. Hotkey assigns to specific command, command then executes code. With new terminal item this is easy to implement. There is a boolean flag which just switch displaying of elements. But with machine list for the exec commands its a bit tricky. Tricky in that way, that we first call run task menu item, task list may contains of not only che task type, but shell and exec. Then, when user pick che task, we show machine list. We can assign hotkey to show the list of machines and switch display, but we need to update the whole mechanism of displaying task list. Because theoretical, user can call hotkey from any place and machine list will be showing. I think it will be not obvious for the end user.

So I propose a bit different approach. At first step show to user non-tooling containers and display the option to show all containers.

machine-picker

@sunix
Copy link
Contributor

sunix commented Jul 15, 2019

@l0rd @vzhukovskii @vparfonov this is not part of the endgame anymore right ?

@vzhukovs
Copy link
Contributor

@sunix this issue is not mentioned in endgame plan

@slemeur
Copy link
Contributor Author

slemeur commented Jul 16, 2019

@vzhukovskii : How the issue is related to hotkeys? I think you are mis-interpreting the description.

Also, I'd like to understand why this issue has been added to the sprint, while it's not part of the endgame and we have a busy list of other issues to address...
cc @vparfonov @l0rd

@vzhukovs
Copy link
Contributor

How the issue is related to hotkeys?

and use a similar mechanism than for opening a terminal

In opening terminal when user opens machine picker he can see only user runtimes and after pressing the hotkey, he can observe all containers. So I've tried to align the same mechanism and for the task execution part.

I think you are mis-interpreting the description.

It's not a problem to update the behavior. Should we display the only user's runtimes and not display plugin containers?

@vzhukovs
Copy link
Contributor

vzhukovs commented Nov 4, 2019

I propose such flow to display containers. There is the same flow to separate user developer containers and tooling containers. The same flow is used when user call action Find command:

When Find command is executed:
Снимок экрана 2019-11-04 в 14 34 15

When new terminal opens:
Снимок экрана 2019-11-04 в 14 34 23

When new task starts:
Снимок экрана 2019-11-04 в 14 34 41

@vparfonov
Copy link
Contributor

@slemeur Please take a look

@slemeur
Copy link
Contributor Author

slemeur commented Nov 6, 2019

Good for me!

@vparfonov vparfonov modified the milestones: 7.4.0, 7.5.0 Nov 14, 2019
@RomanNikitenko RomanNikitenko removed the status/in-progress This issue has been taken by an engineer and is under active development. label Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

6 participants