Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to configure borders in quick pick items list on plugin side #6487

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

vzhukovs
Copy link
Contributor

@vzhukovs vzhukovs commented Nov 4, 2019

What it does

This changes proposal adds ability to create quick open item configured with border and group label used in plugins.

When new terminal opens (mechanism used to create quick open items in extension):
Снимок экрана 2019-11-04 в 14 34 23

When new task starts (mechanism used to create quick open items in plugin):
Снимок экрана 2019-11-04 в 14 34 41

Signed-off-by: Vlad Zhukovskyi vzhukovs@redhat.com

How to test

Devfile to test changes: https://gist.github.com/vzhukovskii/23b275d18af208629648430df251a78e/raw/6451e1d0589cb435bf58208d560fb8006e338cd8/che-dev-workspace.yaml

Steps to test changes manually:

  • clone che-theia and theia
  • checkout to quick_pick_items_ext in che-theia and theia repo
  • build che-theia, then go to dockerfile/theia and build docker image: ./build.sh --build-args:GITHUB_TOKEN=${GITHUB_TOKEN},THEIA_VERSION=master --tag:next --branch:quick_pick_items_ext --git-ref:refs\\/heads\\/quick_pick_items_ext --skip-tests
  • use built docker image eclipse/che-theia:next as image for the main editor in che.

Need for: eclipse-che/che#13390
Linked Che-Theia PR: eclipse-che/che-theia#532

Review checklist

Reminder for reviewers

Signed-off-by: Vlad Zhukovskyi <vzhukovs@redhat.com>
@vzhukovs vzhukovs self-assigned this Nov 4, 2019
@vzhukovs vzhukovs added enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team labels Nov 4, 2019
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code-wise looks good to me, have not tested though

@RomanNikitenko
Copy link
Contributor

I'm going to test the changes tomorrow, sorry for delay.

@RomanNikitenko
Copy link
Contributor

Tested the changes using proposed devfile: items are displayed with group label

@vzhukovs vzhukovs merged commit 8bf4dfc into master Nov 11, 2019
@vzhukovs vzhukovs deleted the quick_pick_items_ext branch November 11, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement issues that are enhancements to current functionality - nice to haves plug-in system issues related to the plug-in system Team: Che-Plugins issues related to the che-plugins team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants