-
Notifications
You must be signed in to change notification settings - Fork 111
Add ability to configure borders in quick pick items list on plugin side #532
Conversation
extensions/eclipse-che-theia-terminal/src/browser/contribution/terminal-quick-open.ts
Outdated
Show resolved
Hide resolved
@RomanNikitenko yes, it's expected behavior |
96dc7e7
to
2c7ab31
Compare
extensions/eclipse-che-theia-terminal/src/common/workspace-service.ts
Outdated
Show resolved
Hide resolved
} | ||
|
||
export function isDevContainer(container: WorkspaceContainer): boolean { | ||
return container.attributes !== undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
!container.attributes
is better because cover null check, but up to you.
Looks like happy tests should be reworked by qa, because UI changed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, the list of containers with group label is displayed:
- at creating a new terminal
- at running a task if
component
is not defined in a configuration
The comment contains case when group label is not displayed for containers
Signed-off-by: Vladyslav Zhukovskyi <vzhukovs@redhat.com>
e4e9ef0
to
28d1c2e
Compare
❌ E2E Happy path tests failed ❗ See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
On this moment we have problem with PR check jobs, all steps from happy path was checked manually. The steps passed. |
Signed-off-by: Vitaliy Gulyy <vgulyy@redhat.com>
What does this PR do?
This changes proposal align behavior to select target container when new terminal opens or new task starts. By the design the flow from the
Find command
action was taken. To separate developer and tooling containers:When
Find command
is executed:When new terminal opens:
When new task starts:
Devfile to test changes: https://gist.github.com/vzhukovskii/23b275d18af208629648430df251a78e/raw/6451e1d0589cb435bf58208d560fb8006e338cd8/che-dev-workspace.yaml
Steps to test changes manually:
[che-theia](https://github.com/eclipse/che-theia)
andtheia
quick_pick_items_ext
inche-theia
andtheia
repoche-theia
, then go to dockerfile/theia and build docker image:./build.sh --build-args:GITHUB_TOKEN=${GITHUB_TOKEN},THEIA_VERSION=master --tag:next --branch:quick_pick_items_ext --git-ref:refs\\/heads\\/quick_pick_items_ext --skip-tests
eclipse/che-theia:next
as image for the main editor in che.Signed-off-by: Vlad Zhukovskyi vzhukovs@redhat.com
What issues does this PR fix or reference?
eclipse-che/che#13390
Release Notes
Add ability to configure borders in quick pick items list on plugin side
Docs PR