Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub PR plugin is not updated after providing an authentication token #16344

Closed
4 of 23 tasks
vinokurig opened this issue Mar 12, 2020 · 2 comments
Closed
4 of 23 tasks

GitHub PR plugin is not updated after providing an authentication token #16344

vinokurig opened this issue Mar 12, 2020 · 2 comments
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.
Milestone
Backlog - Plugins

Comments

@vinokurig
Copy link
Contributor

vinokurig commented Mar 12, 2020 •
edited
Loading

Describe the bug

A GitHub token input does not affects the GitHub plugin until the browser page is not reloaded.

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. Start a workspace with GitHub projects and enabled GitHub PR plugin
  2. Go to GitHub Pull Requests: Manually Provide Authentication Response and input the GitHub token.
    See: nothing happens until the browser page is relaoded:
    video-convert

Expected behavior

The pull request view should be updated automatically after providing the token.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Installation method

  • chectl
  • che-operator
  • minishift-addon
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • other: please specify

Eclipse Che Logs

Additional context
@vinokurig vinokurig added kind/bug Outline of a bug - must adhere to the bug report template. team/plugins area/plugins labels Mar 12, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Mar 12, 2020
@tolusha tolusha added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Mar 13, 2020
@ericwill ericwill added this to the Backlog - Plugins milestone Aug 21, 2020
@ericwill ericwill added area/git lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Aug 21, 2020
@ericwill
Copy link
Contributor

@vinokurig is this one still relevant given we use a different authentication scheme now and newer plugin version?

@vinokurig
Copy link
Contributor Author

@ericwill You are right, it is fixed by eclipse-che/che-plugin-registry#640 and eclipse-che/che-theia#841

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/plugins kind/bug Outline of a bug - must adhere to the bug report template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
Backlog - Plugins
Development

No branches or pull requests
4 participants
@tolusha @ericwill @vinokurig @che-bot