Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the vscode GitHub Pull Request plugin #640

Merged
merged 3 commits into from
Oct 9, 2020
Merged

Update the vscode GitHub Pull Request plugin #640

merged 3 commits into from
Oct 9, 2020

Conversation

vinokurig
Copy link
Contributor

@vinokurig vinokurig commented Oct 7, 2020 •
edited
Loading

Signed-off-by: Igor Vinokur ivinokur@redhat.com

What does this PR do?

Update the vscode GitHub Pull Request plugin with the latest version

depends on eclipse-che/che-theia#841

@vinokurig
Update the vscode GitHub Pull Request plugin
f5207f1 
Signed-off-by: Igor Vinokur <ivinokur@redhat.com>
@che-bot
Copy link
Contributor

che-bot commented Oct 7, 2020

@vinokurig Happy Path PR check [build 352] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/352/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/352/

Depending on failure reason, the artifacts or deployment may not be present.

ericwill
ericwill requested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@ericwill ericwill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new folder with version 0.20.0 and new meta.yaml, instead of editing the existing one. Please also update the vscode-extensions.json entry for this plugin to latest upstream revision (looks like it's 0.20.0).

@che-bot
Copy link
Contributor

che-bot commented Oct 7, 2020

@vinokurig Happy Path PR check [build 353] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/353/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/353/

Depending on failure reason, the artifacts or deployment may not be present.

@vinokurig
Copy link
Contributor Author

@ericwill

Please add a new folder with version 0.20.0 and new meta.yaml, instead of editing the existing one. Please also update the vscode-extensions.json entry for this plugin to latest upstream revision (looks like it's 0.20.0).

Done

@che-bot
Copy link
Contributor

che-bot commented Oct 8, 2020

@vinokurig Happy Path PR check [build 354] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/354/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/354/

Depending on failure reason, the artifacts or deployment may not be present.

@vinokurig vinokurig mentioned this pull request Oct 8, 2020
Merged
@vinokurig
Copy link
Contributor Author

[ci-test]

@ericwill ericwill merged commit 08882d0 into master Oct 9, 2020
@ericwill ericwill deleted the che-16741 branch October 9, 2020 12:10
@benoitf
Copy link
Contributor

benoitf commented Oct 9, 2020

it is not depending on eclipse-che/che-theia#841 ?

@ericwill
Copy link
Contributor

ericwill commented Oct 9, 2020

it is not depending on eclipse/che-theia#841 ?

Sorry thought this one was merged already

@ericwill
Copy link
Contributor

ericwill commented Oct 9, 2020

Actually I think we have a circular dependency as eclipse-che/che-theia#841 (comment) suggests that PR depends on this update 😆

@che-bot
Copy link
Contributor

che-bot commented Oct 9, 2020

@vinokurig Happy Path PR check [build 359] failed.

Re-trigger by [ci-test] or [ci-test-happy-path].

Link URL
console https://ci.centos.org/job/devtools-che-plugin-registry-pr-check-happy-path/359/console
artifacts http://artifacts.ci.centos.org/devtools/che/che-plugin-registry-prcheck/359/

Depending on failure reason, the artifacts or deployment may not be present.

@che-bot che-bot added this to the 7.21 milestone Oct 9, 2020
@vinokurig vinokurig mentioned this pull request Oct 9, 2020
Closed
@ericwill ericwill mentioned this pull request Oct 19, 2020
Closed
@vinokurig vinokurig mentioned this pull request Oct 28, 2020
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwill ericwill ericwill approved these changes

@benoitf benoitf Awaiting requested review from benoitf

@svor svor Awaiting requested review from svor

@tsmaeder tsmaeder Awaiting requested review from tsmaeder

@vitaliy-guliy vitaliy-guliy Awaiting requested review from vitaliy-guliy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.21
Development

Successfully merging this pull request may close these issues.
4 participants
@vinokurig @che-bot @benoitf @ericwill