Register GitHub Authentication provider for the vscode GitHub PR plugin #841

vinokurig · 2020-08-26T14:41:26Z

What does this PR do?

Register authentication provider via the authentication plugin API based on the Che GitHub oAuth, so the native command Github sign in from the PR plugin calls the registered provider.
Remove the temporary command that injects the GitHub token to the vscode PR plugin settings and ask to reload the browser page.
Update the GitHub Plugin API with getUser() function which returns GitHub user info.

depends on eclipse-che/che-plugin-registry#640

What issues does this PR fix or reference?

fixes eclipse-che/che#17684
depends on eclipse-theia/theia#8402

Release Notes

Docs PR

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

che-bot · 2020-08-26T14:59:27Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-08-31T14:53:19Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

azatsarynnyy · 2020-09-15T06:48:06Z

depends on eclipse-che/che#17550

vinokurig · 2020-09-15T07:22:01Z

depends on eclipse-che/che#16741

che-bot · 2020-09-23T09:31:15Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

che-bot · 2020-09-23T12:51:20Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

che-bot · 2020-10-07T08:05:42Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

vinokurig · 2020-10-07T08:40:50Z

[crw-ci-test]

che-bot · 2020-10-07T09:11:52Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

benoitf · 2020-10-07T09:16:48Z

plugins/github-auth-plugin/src/github-auth-plugin.ts

+                    const githubUser = await che.github.getUser();
+                    session = {
+                        id: 'github-session',
+                        accessToken: await che.github.getToken(),


what happen on fresh install, I'm not sure che.github.getToken() or che.github.getUser() is returning something ?

In this case the GitHub authentication page appears:
https://github.com/eclipse/che-theia/blob/2f11124e7de0e50feed25fddf91a9058c37a2a1b/extensions/eclipse-che-theia-plugin-ext/src/browser/oauth-utils.ts#L101-L117
Then if user authenticates it the GitHub token is setup and these functions work as expected.

…PR plugin

che-bot · 2020-10-07T12:39:35Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

vinokurig · 2020-10-07T13:11:03Z

[crw-ci-test]

che-bot · 2020-10-07T13:42:30Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

azatsarynnyy · 2020-10-07T14:53:52Z

generator/tests/init-sources/assembly-example/configs/root-compilation.tsconfig.json

@@ -164,4 +164,4 @@
      "path": "../examples/assembly/compile.tsconfig.json"
    }
  ]
-}
+}


please, revert it to have the checks passed

Done, thank you!

…PR plugin

che-bot · 2020-10-07T15:29:47Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

che-bot · 2020-10-09T09:49:23Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	docker.io/maxura/che-theia:841
che-theia-endpoint-runtime-binary	docker.io/maxura/che-theia-endpoint-runtime-binary:841

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "[crw-ci-test]" to rerun happy path E2E test.

Signed-off-by: Sun Tan <sutan@redhat.com>

vinokurig requested review from benoitf, ericwill, svor, tsmaeder and vitaliy-guliy as code owners August 26, 2020 14:41

vinokurig changed the title ~~Register GitHub Authentication provider for the vscode GitHub PR plugin~~ [WIP] Register GitHub Authentication provider for the vscode GitHub PR plugin Aug 28, 2020

vinokurig force-pushed the che-17684 branch from eb12fb9 to c90565d Compare August 31, 2020 14:38

vinokurig requested review from azatsarynnyy, RomanNikitenko and vzhukovs as code owners August 31, 2020 14:38

vinokurig force-pushed the che-17684 branch from c90565d to 9cc1fd4 Compare September 23, 2020 09:10

vinokurig mentioned this pull request Oct 1, 2020

Align the Comments plugin API with the latest vscode eclipse-theia/theia#8539

Merged

1 task

vinokurig changed the title ~~[WIP] Register GitHub Authentication provider for the vscode GitHub PR plugin~~ Register GitHub Authentication provider for the vscode GitHub PR plugin Oct 7, 2020

Register GitHub Authentication provider for the vscode Github PR plugin

41c6c34

Signed-off-by: Igor Vinokur <ivinokur@redhat.com>

vinokurig force-pushed the che-17684 branch from 4da64b9 to 41c6c34 Compare October 7, 2020 07:31

benoitf reviewed Oct 7, 2020

View reviewed changes

fixup! Register GitHub Authentication provider for the vscode Github …

987222e

…PR plugin

azatsarynnyy approved these changes Oct 7, 2020

View reviewed changes

fixup! Register GitHub Authentication provider for the vscode Github …

d001946

…PR plugin

vinokurig mentioned this pull request Oct 8, 2020

Update the vscode GitHub Pull Request plugin eclipse-che/che-plugin-registry#640

Merged

merge with master

04b27e1

vinokurig merged commit 010cef7 into master Oct 9, 2020

vinokurig deleted the che-17684 branch October 9, 2020 12:36

vinokurig mentioned this pull request Oct 9, 2020

Improve login procedure for GitHub PullRequest Plugin eclipse-che/che#14217

Closed

che-bot added this to the 7.21 milestone Oct 9, 2020

l0rd added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Oct 12, 2020

vinokurig mentioned this pull request Oct 28, 2020

GitHub PR plugin is not updated after providing an authentication token eclipse-che/che#16344

Closed

23 tasks

vinokurig pushed a commit that referenced this pull request Apr 6, 2021

fix(ruby): Re enabling ruby plugin (#841)

7f875a2

Signed-off-by: Sun Tan <sutan@redhat.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Register GitHub Authentication provider for the vscode GitHub PR plugin #841

Register GitHub Authentication provider for the vscode GitHub PR plugin #841

vinokurig commented Aug 26, 2020 •

edited

Loading

che-bot commented Aug 26, 2020

che-bot commented Aug 31, 2020

azatsarynnyy commented Sep 15, 2020

vinokurig commented Sep 15, 2020

che-bot commented Sep 23, 2020

che-bot commented Sep 23, 2020

che-bot commented Oct 7, 2020

vinokurig commented Oct 7, 2020

che-bot commented Oct 7, 2020

benoitf Oct 7, 2020

vinokurig Oct 7, 2020

che-bot commented Oct 7, 2020

vinokurig commented Oct 7, 2020

che-bot commented Oct 7, 2020

azatsarynnyy Oct 7, 2020

vinokurig Oct 7, 2020

che-bot commented Oct 7, 2020

che-bot commented Oct 9, 2020

Register GitHub Authentication provider for the vscode GitHub PR plugin #841

Register GitHub Authentication provider for the vscode GitHub PR plugin #841

Conversation

vinokurig commented Aug 26, 2020 • edited Loading

What does this PR do?

What issues does this PR fix or reference?

Release Notes

Docs PR

Happy Path Channel

che-bot commented Aug 26, 2020

che-bot commented Aug 31, 2020

azatsarynnyy commented Sep 15, 2020

vinokurig commented Sep 15, 2020

che-bot commented Sep 23, 2020

che-bot commented Sep 23, 2020

che-bot commented Oct 7, 2020

vinokurig commented Oct 7, 2020

che-bot commented Oct 7, 2020

benoitf Oct 7, 2020

Choose a reason for hiding this comment

vinokurig Oct 7, 2020

Choose a reason for hiding this comment

che-bot commented Oct 7, 2020

vinokurig commented Oct 7, 2020

che-bot commented Oct 7, 2020

azatsarynnyy Oct 7, 2020

Choose a reason for hiding this comment

vinokurig Oct 7, 2020

Choose a reason for hiding this comment

che-bot commented Oct 7, 2020

che-bot commented Oct 9, 2020

vinokurig commented Aug 26, 2020 •

edited

Loading