You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Multiuser module has infrastructure/openshift submodule where is located only MultiuserInstallerConfigProvisioner which set USER_TOKEN environment variable.
But it may make an impression that multiuser has different implementation of OpenShift infrastructure.
It is needed to create MachineTokenProvider in che-core-api-workspace module and move injection of USER_TOKEN env variable into che/infrastructure/openshift module. Then single user will have a dummy implementation for MachineTokenProvider and multi user che will have an implementation that provides machine token from MachineTokenRegistry#getOrCreateToken.
The text was updated successfully, but these errors were encountered:
sleshchenko
changed the title
[SPI] Rework injecting machine token into OpenShift machine
[SPI] Rework injecting of machine token into OpenShift machine
Oct 5, 2017
sleshchenko
added
status/code-review
This issue has a pull request posted for it and is awaiting code review completion by the community.
and removed
status/open-for-dev
An issue has had its specification reviewed and confirmed. Waiting for an engineer to take it.
status/in-progress
This issue has been taken by an engineer and is under active development.
labels
Oct 11, 2017
Multiuser module has
infrastructure/openshift
submodule where is located only MultiuserInstallerConfigProvisioner which setUSER_TOKEN
environment variable.But it may make an impression that
multiuser
has different implementation of OpenShift infrastructure.It is needed to create
MachineTokenProvider
inche-core-api-workspace
module and move injection ofUSER_TOKEN
env variable intoche/infrastructure/openshift
module. Then single user will have adummy
implementation forMachineTokenProvider
and multi user che will have an implementation that provides machine token from MachineTokenRegistry#getOrCreateToken.The text was updated successfully, but these errors were encountered: