Added MachineTokenProvider interface with different implementations #6700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sleshchenko
added
kind/task
sleshchenko
requested review from
gazarenkov,
skabashnyuk,
garagatyi and
akorneta
skabashnyuk
approved these changes
Oct 12, 2017
gazarenkov
approved these changes
Oct 12, 2017
akorneta
approved these changes
Oct 12, 2017
garagatyi
approved these changes
Oct 12, 2017
riuvshin
approved these changes
Oct 12, 2017
|
Build # 4122 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4122/ to view the results. |
sleshchenko
force-pushed
the
CHE-6587
branch
2 times, most recently
from
f9b7581 to
7ba51ef
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/4126/ |
garagatyi
reviewed
Oct 13, 2017
| this.runtimeIdentity = runtimeIdentity; | ||
| this.machineName = machineName; | ||
| this.servers = servers; | ||
| this.serverCheckerFactory = serverCheckerFactory; | ||
| this.timer = new Timer("ServerReadinessChecker", true); |
There was a problem hiding this comment.
Can you align string constant with the new new name
garagatyi
approved these changes
Oct 13, 2017
| RuntimeIdentity runtimeIdentity, | ||
| String machineName, | ||
| Map<String, ? extends Server> servers, | ||
| ServerCheckerFactory serverCheckerFactory) { | ||
| @Assisted MachineTokenProvider machineTokenProvider) { |
There was a problem hiding this comment.
Am I wrong that assisted annotation should be on other arguments, but not on this one?
There was a problem hiding this comment.
You're correct. I've already fixed it locally.
It is implemented in different ways for single and multiuser packaging
benoitf
removed
the
status/code-review
|
Build # 4139 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4139/ to view the results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds MachineTokenProvider interface. There are different implementations for single and multiuser packagings. With these changes, there is no necessity to override anything for implementations of infrastructures in
che multiuserassembly.It also contains minor cleaning up of jpa tests and OpenShift provisioning.
What issues does this PR fix or reference?
#6587