Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added MachineTokenProvider interface with different implementations #6680

Closed
wants to merge 3 commits into from

Conversation

sleshchenko
Copy link
Member

What does this PR do?

Adds MachineTokenProvider interface. There are different implementations for single and multiuser packagings. With these changes, there is no necessity to override anything for implementations of infrastructures in che multiuser assembly.

It also contains minor cleaning up of jpa tests and OpenShift provisioning.

What issues does this PR fix or reference?

#6587

@sleshchenko sleshchenko added kind/task Internal things, technical debt, and to-do tasks to be performed. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. target/branch Indicates that a PR will be merged into a branch other than master. labels Oct 11, 2017
@sleshchenko sleshchenko self-assigned this Oct 11, 2017
@codenvy-ci
Copy link

Build # 4098 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/4098/ to view the results.

It is implemented in different ways for single and multiuser packaging
@codenvy-ci
Copy link

@skabashnyuk skabashnyuk added this to the 6.0.0-M1 milestone Oct 19, 2017
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. target/branch Indicates that a PR will be merged into a branch other than master.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants