-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#10881 migrate from bower to yarn #10883
Conversation
Can one of the admins verify this patch? |
2 similar comments
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
To builds this, I ran:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bower dependencies can't become devDependencies. They're dependencies. This PR is mixing build and runtime dependencies
According to PR description template https://raw.githubusercontent.com/eclipse/che/master/.github/PULL_REQUEST_TEMPLATE.md
So, please fix PR title before merging. |
PR title fixed, @sleshchenko . Changes requested by @benoitf: move devDeps to prod deps. I also:
Note that this works with node 6.14.4 and npm 3.10.10. When I tried with node 8.11.3 / npm 5.6, the node-gyp failures were recorded as failures, rather than optional warnings, so the build fails. I've not managed to figure out how to tell yarn to ignore node-gyp errors yet. It's also been suggested that we look at migrating from gulp & browserify to webpack, but I think that can be done in a second PR, once this is approved. Can anyone verify this works when you build it locally, etc? Compiles for me but I've no idea what to then run to verify everything LOOKS the same / RUNS the same / WORKS the same. Is there a smoke test doc somewhere I can read? |
move devDeps to prod deps; migrate to bootstrap-styl (replaces bootstrap-stylus); make mvn clean delete yarn.lock; remove ref to tty.isatty Change-Id: Ic93a1191bcb25fdc564b481bc5c5877fc233a617 Signed-off-by: nickboldt <nboldt@redhat.com>
Applying this patch is getting me further in NCL. Can someone have a look and merge it (or something similar, if you don't like all my changes) in time for the 6.11 release? If so, that would be amazing! If not, please let me know why this is rejected or when it can be done in future. |
@nickboldt And there is still bower build in Dockerfile (in the root of dashboard directory). |
@ashumilova I wasn't going to change the dockerfile until I had a working local build ( Can you |
replaced by another PR |
#10881 WIP to migrate from bower to yarn.
Change-Id: Ic93a1191bcb25fdc564b481bc5c5877fc233a617
Signed-off-by: nickboldt nboldt@redhat.com