-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHE-10883 migrate from bower to yarn #11301
Conversation
ci-test |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should fix images and icons
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
ci-test |
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
71a8d9a
to
5f1a247
Compare
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Selenium tests execution on Eclipse Che Multiuser on OCP (https://ci.codenvycorp.com/job/che-pullrequests-test-ocp/894/) doesn't show any regression against this Pull Request. |
dashboard/src/index.ts
Outdated
* Contributors: | ||
* Red Hat, Inc. - initial API and implementation | ||
*/ | ||
export interface ICheWindow extends Window{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing space after Window
Will this change be included in 6.12.0 release? |
Also I just noticed this moves us from node 6.11.2 -> 8.10.0. Will a similar change also happen for the node project in https://github.com/eclipse/che-lib/tree/master/che-terminal-client ? It would be good to be able to build all of Che with the same pod definition (all with the same version of npm/node/mvn/java/golang). |
@AndrienkoAleksandr WDYT? |
@nickboldt for build xterm.js we don't use docker. |
I'm not talking about docker - I asked about node 6 -> 8. You definitely use npm: https://github.com/eclipse/che-lib/blob/master/che-terminal-client/pom.xml#L88 |
@nickboldt I do full rebuild Eclipse CHE quite often. And On the my laptop I set up node 8.9.1. So I do build xterm.js (in the che-lib) with this version and everithing is ok. |
Signed-off-by: Oleksii Orel <oorel@redhat.com>
ci-test |
Results of automated E2E tests of Eclipse Che Multiuser on OCP: |
Signed-off-by: Oleksii Orel oorel@redhat.com
What does this PR do?
Migrate from bower to yarn.
What issues does this PR fix or reference?
#10881
#10883