#13547 add servers on 3000, 9000, & 8080 #13551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Here are the samples associated with che7-preview stack:
and the java-maven stack:
|
…mple projects associated with che7-preview and java-maven stacks will have working preview URLs Change-Id: I9e1afc3ad423c84b6e2e2fb8190f244051d4a6af Signed-off-by: nickboldt <nboldt@redhat.com>
nickboldt
force-pushed
the
13547-missing-server-ports
branch
from
1de207e to
890d858
Compare
nickboldt
changed the title
|
Can one of the admins verify this PR? |
ashumilova
approved these changes
Jun 18, 2019
che-bot
added
the
status/code-review
|
Please make me sure. Does this PR still have any values to merge? |
|
As far as we use defile registry instead of stacks.json makes sense to close the PR. @nickboldt is that ok for you? |
|
Yeah, the correct fix here (if still needed) would be to add missing ports to the devfiles, not to stacks.json. |
|
GH is throwing 500 Server Error at me today so I can't check if this was an
issue for 1.2/6.19.x or 2.0/7.x.
If it's for Che 7, then yes, close it as "not applicable" or "out of date".
If it's for Che 6.19.x, then we could consider it for the next 6.19.x
maintenance release.
…On Thu, Jul 18, 2019 at 3:00 AM Anna Shumilova ***@***.***> wrote:
As far as we use defile registry instead of stacks.json makes sense to
close the PR. @nickboldt <https://github.com/nickboldt> is that ok for
you?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#13551>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABXSDNURPYASRWVEMP5ANTQAAIKNANCNFSM4HYNHSQA>
.
--
Nick Boldt
Principal Software Engineer, RHCSA
Productization Lead :: CodeReady Workspaces
IM: @nickboldt / @nboldt / http://nick.divbyzero.com
<https://red.ht/sig>
TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
@ @redhatnews <https://twitter.com/redhatnews> Red Hat
<https://www.facebook.com/RedHatInc>
<https://www.facebook.com/RedHatInc>
“The Only Thing That Is Constant Is Change” - Heraclitus
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#13547 add server on ports 3000, 9000, and 8080 so the sample projects associated with che7-preview stack will have working preview URLs
Signed-off-by: nickboldt nboldt@redhat.com