Allow Che CLI to run in directory w/o write permissions #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerJewell
added
the
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/323/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/324/ |
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/325/ |
riuvshin
pushed a commit
that referenced
this pull request
Sep 7, 2016
* Detect unknown options * Add windows check
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
…2358) * Detect unknown options * Add windows check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
1: Updates the CLI to write its temporary file into ~/.che/tmpgibberish, which is always writable, instead of writing it into the current directory. In order to do a docker run, temporarily changes the directory location to ~/.che/ to perform the execution.
2: Found reversion on the networking tests. Seems that we reverted back to an old version of the tests. So fixed that.
3: Added in check on boot2docker + windows - to override CHE_DATA_FOLDER to be %USERPROFILE%/.che, if CHE_DATA_FOLDER is not a subset of %USERPROFILE%.
There is no docs impact.