Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read/write instrumentation with LTTng #898

Commits on Sep 8, 2021

  1. Fix dlopen_path test on normal VS/Xcode

    This restores the directories used before the MinGW support was added.
    For some reason, in the CI the VS and Xcode builds do store the output
    in directories not suffixed with Release or Debug, but this is not
    usually the case.  As a consequence, on a typical build with those build
    systems, this test failed.
    
    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Sep 8, 2021
    Configuration menu
    Copy the full SHA
    7465083 View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2021

  1. Avoid some undocumented interfaces in bison

    This fixes incompatibilities with bison 3.8:
    
    * returning user-defined values from yyparse is not supported, this
      works aruond that by storing a more meaningful return value in the
      parser state object;
    
    * the token name table generated by %token-table is deprecated and has
      been for quite some time, and it seems that now the accompanying
      mapping to internal token numbers is gone as well, this uses a hack to
      work around that.
    
    A follow-up fix is needed to remove the use of the token name table
    entirely.  The hack here is attractive only in that it provides a quick
    solution for the failing CI runs on macOS.
    
    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson authored and k0ekk0ek committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    7b19207 View commit details
    Browse the repository at this point in the history
  2. Move parser result into a separate argument

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson authored and k0ekk0ek committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    320f5d0 View commit details
    Browse the repository at this point in the history
  3. Remove Visual Studio analyzer from builds

    The analyzer doesn't do a good job if there are no SAL2 annotations, but
    those annotations are only supported by Visual Studio, the documentation
    is very incomplete and it is (nearly) impossible to get them right
    without actually compiling the code with Visual Studio.  The latter is
    what it makes it really impossible to use them.
    
    That makes dealing with false positives from the Visual Studio analzyer
    far more trouble than it is worth (especially considering we're also
    using the clang and gcc analyzers and Coverity).
    
    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson authored and k0ekk0ek committed Sep 23, 2021
    Configuration menu
    Copy the full SHA
    7b64ecc View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Configuration menu
    Copy the full SHA
    999d6a9 View commit details
    Browse the repository at this point in the history
  2. Use correct offset when serializing type consistency qos

    Signed-off-by: Dennis Potman <dennis.potman@adlinktech.com>
    dpotman authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    a93b0b6 View commit details
    Browse the repository at this point in the history
  3. Fix refcount bug on faulty annotations

    Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
    k0ekk0ek authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    ba32af3 View commit details
    Browse the repository at this point in the history
  4. Fix warning about possible use of uninitialized data

    Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
    k0ekk0ek authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    7707d26 View commit details
    Browse the repository at this point in the history
  5. Fix check of snprintf result

    The length returned by snprintf does not includes the ending
    null. So the test must be changed to ensure that if the final length
    if sadly 64, the library can be found all the time.
    
    Also add little comments.
    
    Signed-off-by: José Bollo <jose.bollo@iot.bzh>
    jobol authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    fd646f0 View commit details
    Browse the repository at this point in the history
  6. Prints diagnostic when plugin fails to load

    A message is emitted to stderr when either the plugin can
    not be loaded or the symbol 'generate' can't be located
    in the loaded plugin.
    
    Logging to sdterr is in wait of some better integration to
    some other logging system.
    
    Signed-off-by: José Bollo <jose.bollo@iot.bzh>
    jobol authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    709f95e View commit details
    Browse the repository at this point in the history
  7. Update quality declaration

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    22f70f1 View commit details
    Browse the repository at this point in the history
  8. Fix bug in tokenizing scoped names

    - The parser was not proceeding correctly in the case of the state
      being IDL_SCAN_ANNOTATION_APPL_SCOPED_NAME
    
    Signed-off-by: Martijn Reicher <martijn.reicher@adlinktech.com>
    reicheratwork authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    22baacb View commit details
    Browse the repository at this point in the history
  9. Fix bug in evaluating bool, char and string literals

    - The parser was setting the node mask to IDL_ANY in stead of the
      correct mask for bool, char and string literals
    
    Signed-off-by: Martijn Reicher <martijn.reicher@adlinktech.com>
    reicheratwork authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    00c6688 View commit details
    Browse the repository at this point in the history
  10. Replace Codecov by Azure Pipelines Code Coverage

    Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
    k0ekk0ek authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    d1a3493 View commit details
    Browse the repository at this point in the history
  11. Fix use-after-free if union creation fails

    Signed-off-by: Dennis Potman <dennis.potman@adlinktech.com>
    dpotman authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    34957ec View commit details
    Browse the repository at this point in the history
  12. Fix use-after-free if enum is used in multiple unions

    Case label destructors deleted the const-expr as opposed to
    unreferencing it causing a use-after-free if the same enum
    was used in more than one union.
    
    Fixes eclipse-cyclonedds#946.
    
    Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
    k0ekk0ek authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    ac2c563 View commit details
    Browse the repository at this point in the history
  13. Remove annotation_appl midrule action

    Destructors are not executed for untyped midrule actions because Bison
    does not know which destructor to run. annotation_appl nodes were not
    cleaned up if the annotation_appl could not be successfully finalized.
    Remove use of midrule actions in annotation_appl as some platforms still
    ship with Bison 3.0.4.
    
    Fixes eclipse-cyclonedds#950.
    
    Signed-off-by: Jeroen Koekkoek <jeroen@koekkoek.nl>
    k0ekk0ek authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    92abf6e View commit details
    Browse the repository at this point in the history
  14. Add python idl locator to idlc

    thijsmie authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    e62a87a View commit details
    Browse the repository at this point in the history
  15. MCPP: cmake changes to remove check_target_cpu. Since we are targetin…

    …g 'C' as a language platform-specific macros are irrelevant for idlc, and this is a blocker for compiling mac universal binaries.
    thijsmie authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    3c69a5c View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    fdce92f View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    f802793 View commit details
    Browse the repository at this point in the history
  18. Add coverity modelling file

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    61348b0 View commit details
    Browse the repository at this point in the history
  19. Propagate envvar expansion error in config

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    2ec1ed6 View commit details
    Browse the repository at this point in the history
  20. Handle too deeply nested XML configs

    There is a maximum nesting depth for the configuration that is
    determined by the internal configuration tables.  Simply aborting the
    interpretation of the XML input on the first unrecognized element item
    would guarantee never exceeding the maximum nesting depth.  As an error
    handling strategy this is less user-friendly than ignoring some of the
    input, attempting to interpret the remainder and reporting any further
    issues.
    
    This commit makes it abort the interpretation as soon as the maximum
    nesting depth is reached, in all other cases it continues and reports as
    many issues with the configuration as it can.
    
    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    bee385a View commit details
    Browse the repository at this point in the history
  21. Test handling invalid envvar expansion in config

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    a35ce4d View commit details
    Browse the repository at this point in the history
  22. Test too deeply nested XML in configurations

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    c8d4ab4 View commit details
    Browse the repository at this point in the history
  23. Fix for issue eclipse-cyclonedds#968

    - This fixes eclipse-cyclonedds#968
    - Add a byte swap to the participant GUID prefix
    
    Signed-off-by: Martijn Reicher <martijn.reicher@adlinktech.com>
    reicheratwork authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    7baf8cc View commit details
    Browse the repository at this point in the history
  24. Fix use of non-existent paths when building as a subproject

    CMAKE_SOURCE_DIR always points to the top-level CMake project, so if
    CycloneDDS was included as a gitmodule or pulled in using CMake
    FetchContent, the CMake step would fail with errors like
    
    ```
    CMake Error at cyclonedds/src/tools/idlc/CMakeLists.txt:52 (file):
    file failed to open for reading (No such file or directory):
    /home/robin/dds-project/src/ddsrt/include/getopt.h.in
    
    CMake Error: File /home/robin/dds-project/src/ddsrt/src/getopt.c does not exist.
    CMake Error at cyclonedds/src/tools/idlc/CMakeLists.txt:61 (configure_file):
    configure_file Problem configuring file
    
    CMake Error at cyclonedds/src/tools/idlc/CMakeLists.txt:95 (include):
    include could not find load file:
    /home/robin/dds-project/cmake/Modules/Generate.cmake
    ```
    
    This commit replaces CMAKE_SOURCE_DIR with <PROJECT_NAME>_SOURCE_DIR, a
    variable that always points to the source dir of the named project.
    
    See:
    https://cmake.org/cmake/help/v3.21/variable/CMAKE_SOURCE_DIR.html
    https://cmake.org/cmake/help/v3.21/variable/PROJECT-NAME_SOURCE_DIR.html
    
    Signed-off-by: Robin Lindén <_@robinlinden.eu>
    robinlinden authored and eboasson committed Oct 8, 2021
    Configuration menu
    Copy the full SHA
    4bab618 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Bump version number to 0.8.1

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    0131940 View commit details
    Browse the repository at this point in the history
  2. Rename libidl to libcycloneddsidl

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    c59f752 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2021

  1. Fix warning when building CycloneDDS with gcc 11.

    gcc 11 warns that there is a conversion from 'long int'
    to 'uint32_t' when assigning the value of PTHREAD_STACK_MIN
    to tattr.stackSize.  It's pedantically correct; tattr.stackSize
    is a uint32_t, and PTHREAD_STACK_MIN is either an integer (if
    it is hard-coded), or the result of calling sysconf(), which
    always returns a long.  In either case it is a signed value,
    so we should explicitly cast it to uint32_t here.  This quiets
    the warning.
    
    Signed-off-by: Chris Lalancette <clalancette@openrobotics.org>
    clalancette authored and eboasson committed Nov 21, 2021
    Configuration menu
    Copy the full SHA
    876f149 View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2021

  1. Detect overflow in idlc when stashing instructions

    This makes idlc show an error message in case the maximum number
    of instructions is reached. Because of 16-bits offset fields in the
    instructions, the maximum number of instructions that can be used
    is limited to 65k.
    
    Signed-off-by: Dennis Potman <dennis.potman@adlinktech.com>
    dpotman authored and eboasson committed Dec 23, 2021
    Configuration menu
    Copy the full SHA
    8e7fd85 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2022

  1. Check package.xml and CMakeLists.txt are the same

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    af7de84 View commit details
    Browse the repository at this point in the history
  2. Bump version to 0.8.2

    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    d63de72 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Set OpenSSL API compatibility to 1.1.1

    This suppresses deprecation warnings from OpenSSL 3.0. It is not a
    proper fix, but the OpenSSL documentation on how to deal with the
    deprecations is such that it will take some time to fix this.
    
    Signed-off-by: Erik Boasson <eb@ilities.com>
    eboasson committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    93fdedc View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2022

  1. Add read/write instrumentation with LTTng

    Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
    christophebedard committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    57efec8 View commit details
    Browse the repository at this point in the history
  2. Remove -rdynamic

    Signed-off-by: Christophe Bedard <bedard.christophe@gmail.com>
    christophebedard committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    21d447c View commit details
    Browse the repository at this point in the history