Moved Nexus URLs to properties. #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Kraus <Tomas.Kraus@oracle.com>
romain-grecourt
approved these changes
Jan 9, 2020
bshannon
approved these changes
Jan 9, 2020
lukasj
reviewed
Jan 9, 2020
| --> | ||
| <release.arguments></release.arguments> | ||
| </properties> | ||
|
|
There was a problem hiding this comment.
just a nit-pick - why exactly has this code been moved around? It is creating a mess in history (aka git blame) as well as the PR harder to review (one needs to go through all lines to find changes). Probably nothing that important within the context of this project but anyway...
There was a problem hiding this comment.
I'm assuming this nit should not hold up moving forward on this.
There was a problem hiding this comment.
Think it's better human readable when you declare properties before using them. But this is not important.
There was a problem hiding this comment.
Think it's better human readable when you declare properties before using them.
Agreed!!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also moved properties above distributionManagement to declare sonatype properties before they are used.