Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved Nexus URLs to properties. #57

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Moved Nexus URLs to properties. #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 18 additions & 16 deletions parent/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,19 @@
</mailingList>
</mailingLists>

<properties>
<sonatypeOssDistMgmtNexusUrl>https://jakarta.oss.sonatype.org/</sonatypeOssDistMgmtNexusUrl>
<sonatypeOssDistMgmtSnapshotsUrl>${sonatypeOssDistMgmtNexusUrl}content/repositories/snapshots/</sonatypeOssDistMgmtSnapshotsUrl>
<sonatypeOssDistMgmtStagingUrl>${sonatypeOssDistMgmtNexusUrl}content/repositories/staging/</sonatypeOssDistMgmtStagingUrl>
<sonatypeOssDistMgmtReleasesUrl>${sonatypeOssDistMgmtNexusUrl}service/local/staging/deploy/maven2/</sonatypeOssDistMgmtReleasesUrl>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!--
Initialize release.arguments to empty, otherwise if not defined
it can fail the release plugin.
-->
<release.arguments></release.arguments>
</properties>

<distributionManagement>
<snapshotRepository>
<id>ossrh</id>
Expand All @@ -109,17 +122,6 @@
</repository>
</distributionManagement>

<properties>
<sonatypeOssDistMgmtSnapshotsUrl>https://jakarta.oss.sonatype.org/content/repositories/snapshots/</sonatypeOssDistMgmtSnapshotsUrl>
<sonatypeOssDistMgmtReleasesUrl>https://jakarta.oss.sonatype.org/service/local/staging/deploy/maven2/</sonatypeOssDistMgmtReleasesUrl>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<!--
Initialize release.arguments to empty, otherwise if not defined
it can fail the release plugin.
-->
<release.arguments></release.arguments>
</properties>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nit-pick - why exactly has this code been moved around? It is creating a mess in history (aka git blame) as well as the PR harder to review (one needs to go through all lines to find changes). Probably nothing that important within the context of this project but anyway...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this nit should not hold up moving forward on this.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's better human readable when you declare properties before using them. But this is not important.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's better human readable when you declare properties before using them.

Agreed!!!

<build>
<pluginManagement>
<plugins>
Expand All @@ -139,7 +141,7 @@
<version>1.6.8</version>
<configuration>
<serverId>ossrh</serverId>
<nexusUrl>https://jakarta.oss.sonatype.org/</nexusUrl>
<nexusUrl>${sonatypeOssDistMgmtNexusUrl}</nexusUrl>
<autoReleaseAfterClose>false</autoReleaseAfterClose>
<!-- Skip based on the maven.deploy.skip property -->
<skipNexusStagingDeployMojo>${maven.deploy.skip}</skipNexusStagingDeployMojo>
Expand Down Expand Up @@ -247,7 +249,7 @@
<repository>
<id>sonatype-nexus-snapshots</id>
<name>Sonatype Nexus Snapshots</name>
<url>https://jakarta.oss.sonatype.org/content/repositories/snapshots</url>
<url>${sonatypeOssDistMgmtSnapshotsUrl}</url>
<releases>
<enabled>false</enabled>
</releases>
Expand All @@ -260,7 +262,7 @@
<pluginRepository>
<id>sonatype-nexus-snapshots</id>
<name>Sonatype Nexus Snapshots</name>
<url>https://jakarta.oss.sonatype.org/content/repositories/snapshots</url>
<url>${sonatypeOssDistMgmtSnapshotsUrl}</url>
<releases>
<enabled>false</enabled>
</releases>
Expand All @@ -284,7 +286,7 @@
<repository>
<id>sonatype-nexus-staging</id>
<name>Sonatype Nexus Staging</name>
<url>https://jakarta.oss.sonatype.org/content/repositories/staging</url>
<url>${sonatypeOssDistMgmtStagingUrl}</url>
<releases>
<enabled>true</enabled>
</releases>
Expand All @@ -297,7 +299,7 @@
<pluginRepository>
<id>sonatype-nexus-staging</id>
<name>Sonatype Nexus Staging</name>
<url>https://jakarta.oss.sonatype.org/content/repositories/staging</url>
<url>${sonatypeOssDistMgmtStagingUrl}</url>
<releases>
<enabled>true</enabled>
</releases>
Expand Down