Helidon cdi tck patch #23990
Merged
Helidon cdi tck patch #23990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Helidon PR made: helidon-io/helidon#4382 |
|
Probably some extra dependencies need to be added to the embedded config: |
The embedded dependencies needed not inlining, as by default they overwrite classes from the main module. This isn't the case when using the 'unpackBundle' option, but that causes module-info files from the dependencies to break compilation. A sensible option seems to be to not inline the dependencies. Note that the overwritten class causes the single artifact it comes from to be inlined. Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
The Helidon Config CDI extension will no longer throw exceptions when synthetic observers are encountered. Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
Exceptions are stored in this package, so need exposing. Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
arjantijms
approved these changes
Jun 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new Config implementation will throw an exception when a synthetic observer is registered. This change patches the CDI Extension class to ignore these synthetic observers.
Observing ConfigProperties isn't a valid use of MP Config anyway, so no functionality is lost.