3.x - MP Config - CDI TCK Synthetic Observers Fix #4382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CDI TCK will fail against any container with the ConfigCdiExtension registered, as synthetic observers don't contain any annotated method. This causes a NPE during the 'ProcessObserverMethod'. The test simply registers an observer and makes sure it runs. Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
This change is made to make the CDI synthetic observer test pass. These events can be ignored, as it's not a valid use of MP Config. Signed-off-by: Matthew Gill <matthew.gill@live.co.uk>
MattGill98
changed the title
|
@MattGill98 Can you please sign the OCA https://github.com/oracle/helidon/blob/master/CONTRIBUTING.md#code, as its required for "Contributing to Project Helidon"? |
barchetta
changed the title
oracle-contributor-agreement
bot
added
the
OCA Required
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CDI TCK will fail against any container with the ConfigCdiExtension registered as synthetic observers don't contain any annotated method, which causes a NPE during the 'ProcessObserverMethod'.
These synthetic events can be safely ignored, as it isn't a valid use of MP Config.
Note that this was discovered when using the MP Config implementation in GlassFish.