DOL module vs. technical debt: generics

[dmatej]

This PR is rather a "feature branch merge" than single fix, because all changes were done with a target to reduce the extreme tech debt of the DOL modules (deployment). Before the merge I would like to run all available tests to ensure that nothing broke, including TCK.

• I tried to add generics where it was possible and known
• Fixed issue Need more descriptive error message in case of an invalid schema #23601 and several similar unresolved messages
• Removed some deprecated or unused methods
• Fixed IO leaks in DOL

[dmatej]

Note for myself - ejb_group_embedded passed locally twice.

[dmatej]

I will pause now, or slow down ... I will create another parallel PR for the TCK runner ... so I can ensure that this huge PR will not break anything. I committed part by part last week, because I could not find mistake I did ... now I found it. When I replaced "...Interceptors" string by Interceptor.class.getName() ... yeah, that missing s was it :-D

Bad was that I could not find it so long, good is that it forced me to analyze the API (broken, leaking) deeply and add some notes how to clean it up so it would make sense. After finishing this PR DOL will not be a scary monster any more :-) - despite it doesn't look like that, the worst part is done. The more code changes will come yet, but they should be much safer.

But again, TCK first.

[dmatej]

I'm yet passing TCK tests which failed yesterday, but it seems this should be the last fix. Refactoring will continue, but it would be good to have some safe point not just in the dev branch ...

04:02:19.443     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/lite/tx/cm/singleton/annotated/Client.java#localRequiresNewTest_from_ejbembed
04:02:19.443     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/lite/tx/cm/singleton/annotated/Client.java#localRequiresNewTest_from_ejblitejsp
04:02:19.443     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/lite/tx/cm/singleton/annotated/Client.java#localRequiresNewTest_from_ejbliteservlet
04:02:19.443     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/lite/tx/cm/singleton/annotated/Client.java#localRequiresNewTest_from_ejbliteservlet2
04:02:19.443     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/lite/tx/cm/singleton/annotated/JsfClient.java#localRequiresNewTest_from_ejblitejsf

ejb30/lite/tx/cm/singleton/annotated passed locally now.

06:21:08.172     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/bb/session/stateful/cm/allowed/Client.java#afterCompletionTest
06:21:08.172     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/bb/session/stateless/cm/allowed/Client.java#postInvokeTest
06:21:08.172     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/bb/session/stateless/cm/allowed/Client.java#preInvokeTest

ejb30/bb/session/stateful/cm/allowed passed locally now.
ejb30/bb/session/stateless/cm/allowed passed locally now.

04:40:17.148     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/timer/interceptor/aroundtimeout/singleton/annotated/Client.java#aroundTimeoutMethod_from_ejbliteservlet
04:40:17.148     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/timer/interceptor/aroundtimeout/singleton/annotated/Client.java#aroundTimeoutMethod2_from_ejbliteservlet
04:40:17.148     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/timer/interceptor/aroundtimeout/singleton/annotated/Client.java#invocationContextMethods_from_ejbliteservlet
04:40:17.148     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/timer/schedule/tz/Client.java#allTZ_from_ejbliteservlet
04:40:17.148     [runcts] OUT => [javatest.batch] FAILED........com/sun/ts/tests/ejb30/timer/schedule/tz/Client.java#shanghaiAndArgentinaTZ_from_ejbliteservlet

ejb30/timer/interceptor/aroundtimeout/singleton/annotated passed locally now
Those two TZ tests locally failed, but that might be caused by local TZ on my laptop.

Failures: 
02:26:03.528  [ERROR]   JAXRSClientIT.deleteWithGenericTypeStringTest:135->JAXRSClientIT.deleteWithGenericTypeStringTest:236->JAXRSClientIT.checkFutureString:1915 Future cannot be done, yet! ==> expected: <true> but was: <false>
02:26:03.529  [ERROR]   JAXRSClientIT.getWithResponseClassTest:187->JAXRSClientIT.getWithResponseClassTest:370->JAXRSClientIT.checkFutureOkResponse:1909 Future cannot be done, yet! ==> expected: <true> but was: <false>
02:26:03.529  [ERROR]   JAXRSClientIT.getWithStringClassTest:175->JAXRSClientIT.getWithStringClassTest:356->JAXRSClientIT.checkFutureString:1915 Future cannot be done, yet! ==> expected: <true> but was: <false>
02:26:03.529  [ERROR]   JAXRSClientIT.optionsWithStringClassTest:255->JAXRSClientIT.optionsWithStringClassTest:1095->JAXRSClientIT.checkFutureString:1915 Future cannot be done, yet! ==> expected: <true> but was: <false>
02:26:03.529  [ERROR]   JAXRSClientIT.postTest:307->JAXRSClientIT.postTest:1264->JAXRSClientIT.checkFutureOkResponse:1909 Future cannot be done, yet! ==> expected: <true> but was: <false>
02:26:03.529  [ERROR]   JAXRSClientIT.putTest:371->JAXRSClientIT.putTest:1476->JAXRSClientIT.checkFutureOkResponse:1909 Future cannot be done, yet! ==> expected: <true> but was: <false>
02:26:03.529  [ERROR]   JAXRSClientIT.putWithGenericTypeResponseTest:419->JAXRSClientIT.putWithGenericTypeResponseTest:1611->JAXRSClientIT.checkFutureOkResponse:1909 Future cannot be done, yet! ==> expected: <true> but was: <false>
02:26:03.529  [ERROR]   JAXRSClientIT.traceTest:435->JAXRSClientIT.traceTest:1686->JAXRSClientIT.checkFutureOkResponse:1909 Future cannot be done, yet! ==> expected: <true> but was: <false>
02:26:03.529  [ERROR]   JAXRSClientIT.traceWithGenericTypeStringTest:471->JAXRSClientIT.traceWithGenericTypeStringTest:1796->JAXRSClientIT.checkFutureString:1915 Future cannot be done, yet! ==> expected: <true> but was: <false>

REST passed locally twice, probably some issue with the Jenkins machine (cpu overload? 18 parallel docker machines)