Fixes to be able to run the TCK on custom Jenkins instance #24108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Sep 14, 2022
•
dmatej
commented
- old authentication TCK 3.0.0 is based on Ant and it still steals logging.properties from GlassFish and uses them on clients. That leads to a deadlock on client, but not when we switch the order of handlers.
- settings.xml on Jenkins redefines path to the local m2 cache, so we respect it inside the runner to avoid redundant downloads.
- added hostname configuration for the mail server.
- Tested locally and on private Jenkins instance
- Execution on the private Jenkins depends on rebuilt JEE 10 zip including these two:
- Possibility to reconfigure GlassFish logging configuration jakartaee/platform-tck#1115
- Refactored and optimized run_jakartaeetck.sh jakartaee/platform-tck#1118
- However the Eclipse's Jenkins doesn't depend on these changes.
- seems the TCK wasn't rebuilt for some time ... https://ci.eclipse.org/jakartaee-tck/job/jakartaee-tck/job/master/
arjantijms
approved these changes
Sep 14, 2022
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- TCK authentication tests ended in deadlock, because the TCK client steals logging.properties from the server (wrong idea, 3 JVMs using same file - server.log). It is because GlassFishLogHandler redirects standard output streams to the server.log file, then SimpleLogHandler uses new streams, which situation leads to a deadlock. - GJULE LogManager prevents that by saving original streams on startup, so whatever happens later, it still has original values available. JUL doesn't have this mechanism. - So in this commit I am just switching the order, so SimpleLogHandler is configured first with original values. - However, this commit doesn't fix the issue where TCK steals server's cfg file. Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- to be able to customize local maven repo path on jenkins Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Added MAIL_HOST Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.