Possibility to reconfigure GlassFish logging configuration #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- important when reproducing some issues Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
arjantijms
approved these changes
Sep 6, 2022
|
Hi, @gurunrao , if you would merge this soon, I would rebase then and create anoher PR fixing several serious issues in the run_jakartaee.sh (correct shutdown of everything started, redundant failing asadmin calls). |
gurunrao
approved these changes
Sep 7, 2022
dmatej
added a commit
to dmatej/glassfish
that referenced
this pull request
Sep 7, 2022
…eanup - note: depends on PR for the TCK, but can run even without that: jakartaee/platform-tck#1115 Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
dmatej
added a commit
to dmatej/glassfish
that referenced
this pull request
Sep 7, 2022
…eanup - note: depends on PR for the TCK, but can run even without that: jakartaee/platform-tck#1115 Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Added possibility to provide custom logging.properties. Default is using the configuration provided with GlassFish.
Additional context
This change is extremely useful when we need to analyze what happened and why, or even compare logs between GlassFish versions. (kdiff3 in Kubuntu is great for that as it can ignore some patterns, ie. timestamp).
Two additional commits
rm-generated-shscript I created recently in 5e8abe0CC @alwin-joseph @anajosep @arjantijms @cesarhernandezgt @dblevins @m0mus @edbratt @gurunrao @jansupol @jgallimore @kazumura @kwsutter @LanceAndersen @bhatpmk @RohitKumarJain @shighbar @gthoman @brideck @scottmarlow