Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: Navigation from header facet causes the value EL to be re-evaluated #5213

Closed
mihaiDumea opened this issue Feb 15, 2023 · 2 comments
Labels
Milestone

Comments

@mihaiDumea
Copy link

Navigation from header facet causes the value EL to be re-evaluated, recreating the bean referenced by the EL in a new scope. This recreation is unnecessary as is for no use and may cause problems. This doesn't happen for navigation from table rows.

To Reproduce

Also reported here primefaces/primefaces#9793

BalusC added a commit that referenced this issue Jul 23, 2023
RowIndex/DataModel of UIData doesn't need to be reset when broadcasted
row index is same as current row index; noticed same thing on UIRepeat
as well so also improved over there
@BalusC BalusC added this to the 2.3.21 milestone Jul 23, 2023
@BalusC BalusC added the 2.3 label Jul 23, 2023
BalusC added a commit that referenced this issue Jul 29, 2023
Further improved to only skip index setting when old+new are both -1
@mnriem
Copy link
Contributor

mnriem commented Sep 5, 2023

@BalusC What timeframe are you looking for cutting the last 2.3 release?

@BalusC
Copy link
Contributor

BalusC commented Sep 6, 2023

I wanted to release it as soon as PRs are reviewed+merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants