Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RowIndex/DataModel of UIData doesn't need to be reset when broadcasted row index and current row index are both -1; noticed same thing on UIRepeat as well so also improved over there #5287

Merged
merged 2 commits into from
Sep 7, 2023
Merged

RowIndex/DataModel of UIData doesn't need to be reset when broadcasted row index and current row index are both -1; noticed same thing on UIRepeat as well so also improved over there #5287

merged 2 commits into from
Sep 7, 2023

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Jul 23, 2023

@BalusC
https://github.com/eclipse-ee4j/mojarra/issues/5213
4f8d049 
RowIndex/DataModel of UIData doesn't need to be reset when broadcasted
row index is same as current row index; noticed same thing on UIRepeat
as well so also improved over there
@BalusC
Copy link
Contributor Author

BalusC commented Jul 23, 2023 •
edited
Loading

Don't merge yet I want to run TCK on this.

Update: TCK passed localhost 👍

@BalusC BalusC added this to the 2.3.21 milestone Jul 23, 2023
@BalusC BalusC added the 2.3 label Jul 23, 2023
@BalusC
https://github.com/eclipse-ee4j/mojarra/issues/5213
37eaf36 
Further improved to only skip index setting when old+new are both -1
@BalusC
Copy link
Contributor Author

BalusC commented Sep 2, 2023

@arjantijms can you please review this?

@BalusC BalusC mentioned this pull request Sep 2, 2023
Closed
@arjantijms arjantijms merged commit a86a228 into 2.3 Sep 7, 2023
@arjantijms arjantijms deleted the mojarra_issue_5213 branch September 7, 2023 10:57
@BalusC BalusC changed the title RowIndex/DataModel of UIData doesn't need to be reset when broadcasted row index is same as current row index; noticed same thing on UIRepeat as well so also improved over there RowIndex/DataModel of UIData doesn't need to be reset when broadcasted row index and current row index are both -1; noticed same thing on UIRepeat as well so also improved over there Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arjantijms arjantijms arjantijms approved these changes

Assignees

@BalusC BalusC

Labels
2.3
Projects
None yet
Milestone
2.3.21
Development

Successfully merging this pull request may close these issues.
2 participants
@BalusC @arjantijms