Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: API References Implementation Class #5484

Closed
volosied opened this issue Aug 16, 2024 · 0 comments
Closed

Bug: API References Implementation Class #5484

volosied opened this issue Aug 16, 2024 · 0 comments
Milestone
4.1.2

Comments

@volosied
Copy link
Contributor

The jakarta.faces.context.FacesContext imports the implementation class com.sun.faces.config.InitFacesContext. This reference was added in 4.1.0 via the following commit: 6d7d667#diff-39da5308af272503db12b96df31c5c3b1fda2997e336bd6d982631fe3328e13dR26-R67

Should the initContextServletContext use the FacesContext
class instead as the parametrized type?

This was created as a follow-up to our challenge: jakartaee/faces#1957
@volosied volosied mentioned this issue Aug 16, 2024
Open
BalusC added a commit that referenced this issue Aug 26, 2024
@BalusC
Fix #5484: api classes should not have impl dependencies
7e5c5b7
@BalusC BalusC mentioned this issue Aug 26, 2024
Merged
@BalusC BalusC added this to the 4.1.2 milestone Aug 26, 2024
BalusC added a commit that referenced this issue Aug 31, 2024
@BalusC
Merge pull request #5485 from eclipse-ee4j/issue_5484_remove_impl_spe…
ee908d2 
…cific_dependency_from_api_class

Fix #5484: api classes should not have impl dependencies
@BalusC BalusC closed this as completed Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.1.2
Development

No branches or pull requests
2 participants
@BalusC @volosied