Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5484: api classes should not have impl dependencies #5485

Merged

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Aug 26, 2024

@BalusC BalusC merged commit ee908d2 into 4.1 Aug 31, 2024
3 checks passed
@BalusC BalusC deleted the issue_5484_remove_impl_specific_dependency_from_api_class branch August 31, 2024 12:39
@volosied
Copy link
Contributor

volosied commented Nov 4, 2024

@arjantijms @BalusC

This change did not make it in to 4.1.1. https://repo1.maven.org/maven2/jakarta/faces/jakarta.faces-api/4.1.1/

The source shows:

import com.sun.faces.config.InitFacesContext;
...

    private static final ConcurrentHashMap<Thread,FacesContext> threadInitContext = new ConcurrentHashMap<>(2);
    private static final ConcurrentHashMap<Thread,InitFacesContext> initContextServletContext = new ConcurrentHashMap<>(2);

Can we get another release?

@BalusC
Copy link
Contributor Author

BalusC commented Nov 5, 2024

Nope it's in Mojarra 4.1.2 which was released yday. I don't know the correct procedure to release the API JAR, only @arjantijms does. While at it can you please document the procedure so others can do it in the future as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants