Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MOJARRA_5375] The jfwid contains the session ID #5395

Closed
wants to merge 218 commits into from

Conversation

BalusC
Copy link
Contributor

@BalusC BalusC commented Feb 10, 2024

Original PR for #5375 was against master instead of 4.0 #5376

So here's a cherrypick for 4.0.

pizzi80 and others added 30 commits June 27, 2022 12:22
Signed-off-by: pizzi80 <paolo@given2.com>
Maven
 - Removed yuicompressor (dead project with no support for ES6+ js)
 + Added Google Closure maven plugin for minification

Faces JS
 + tested and minified with ECMASCRIPT5_STRICT profile of Google Closure
 + use strict
 + const and let instead of var
 - Removed IE-5-6-7-8-9-10 support
 - Removed IE 5-6-7 hacks and memory hacks
 - Removed FrameTransport
 - Removed / Commented out unused and very old functions and code
 + FormData for File upload
 + Many minor optimizations
 + for..of instead of for with index
 + Partial Submit ported and adapted from OmniFaces
 + 10 kB Minified and Gzipped

Signed-off-by: pizzi80 <paolo@given2.com>
Update readme for 4.0 and faces next
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Set version for Mojarra .Next (4.1 for now)
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Clarified spec wrt location of f:metadata
Let Mojarra log a WARNING for now
…_spec_wrt_location_of_f-metadata

Clarified spec wrt location of f:metadata
- add back id attribute to VDL of h:head and h:body
- fix HeadRenderer to only output it when actually specified
- fix BodyRenderer to only output it when HTML5 doctype is used
… and h:body - fix HeadRenderer to only output it when actually specified - fix BodyRenderer to only output it when HTML5 doctype is used"

This reverts commit ba403c1.
…f h:head and h:body - fix HeadRenderer to only output it when actually specified - fix BodyRenderer to only output it when HTML5 doctype is used""

This reverts commit baf7998.
Specify ExternalContext#setResponseContentLengthLong
Implement ExternalContext#setResponseContentLengthLong
Add ExternalContextWrapper#setResponseContentLengthLong
HeadRenderer encodeBegin complexity was already removed since
introduction of new Doctype interface, so it can now be tested
…nalContext_setResponseContentLengthLong

Add ExternalContext#setResponseContentLengthLong
arjantijms and others added 12 commits December 11, 2023 14:37
Update dependencies to their M1 versions where applicable, and update
code to support this.

Set release target to JDK 17, and removed some resulting warnings.

Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
Support for the Jakarta EE 11 M1 release
Modify ClientWindowImpl to generate window ID w/o using session id
Add TokenGenerator from MyFaces
@BalusC BalusC added this to the 4.0.6 milestone Feb 10, 2024
BalusC and others added 7 commits February 11, 2024 12:45
…t() when INTERPRET_EMPTY_STRING_SUBMITTED_VALUES_AS_NULL=true #5386"

This reverts commit 081e6ea.
interpreted as -1 which was disallowed when put back as numeric input
attribute which only allowed positive integers
interpreted as -1 which was disallowed when put back as numeric input
attribute which only allowed positive integers
git@github.com:eclipse-ee4j/mojarra.git into fix_tck_for_mojarra_4.1
…ment

Default encoding should be prechecked
Copy link
Contributor

@jasondlee jasondlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@mnriem mnriem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it not be dual licensed here. Is that allowed? @arjantijms You know?

@BalusC
Copy link
Contributor Author

BalusC commented Feb 18, 2024

Bah I accidentally merged 4.1 instead of 4.0 into this branch. I will redo.

Wrt the license concern, I'll replace the approach by just java.util.UUID.

@BalusC BalusC closed this Feb 18, 2024
@BalusC BalusC deleted the mojarra_issue_5375_the_jfwid_contains_the_session_id branch February 18, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.