#5375: jfwid may not leak session id #5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BalusC
changed the title
arjantijms
approved these changes
Feb 20, 2024
arjantijms
deleted the
mojarra_issue_5375_jfwid_may_not_leak_session_id
branch
mnriem
reviewed
Feb 20, 2024
|
Nope. It's now an UUID. Which is "too much" actually because it only needs to be session scoped. But that's OK for now and much easier to do. It's internally already using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR for #5375 was against master instead of 4.0 #5376. I cherrypicked it for 4.0 #5395 but there was a license concern (and I accidentally upmerged with 4.1 instead of 4.0) so I declined it.
Here's a improved and license safe impl. I will update 4.0/5.0 accordingly once PR is approved.