GLSP-1096: Update to sprotty 0.14.0 #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code looks good, thank you! Or is there something wrong with my setup? |
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Aug 25, 2023
Update Theia integration code to conform to latest client changes Requires eclipse-glsp/glsp-client#277
|
The integration projects have not been updated to the latest client state yet. |
Update to sprotty 0.14.0 and adapt code to conform to latest changes/API breaks. With 0.14.0 the `ToolManager API` was deprecated and it will be removed in future versions. The intention is that this API moves to GLSP as it is only used there => refactor `ToolManager API` GLSP-960: Make glspClient retrieval async Fixes eclipse-glsp/glsp#1096 Fixes eclipse-glsp/glsp#1094
|
@planger I rebased this PR on the latest master to resolve conflicts. Are there any open issues or can we go ahead and merge this? |
|
I think I still can't test this unfortunately, because I get the same build errors as in eclipse-glsp/glsp-theia-integration#174 also with eclipse-glsp/glsp-theia-integration#174. |
|
Strange. It works fine for me.Nevertheless it's also fine to just test the
client change and then test this
integration change separately. We need to merge the client change
beforehand anyways.
…On Fri, Aug 25, 2023, 10:56 Philip Langer ***@***.***> wrote:
I think I still can't test this unfortunately, because I get the same
build errors as in eclipse-glsp/glsp-theia-integration#174
<eclipse-glsp/glsp-theia-integration#174> also
with eclipse-glsp/glsp-theia-integration#174
<eclipse-glsp/glsp-theia-integration#174>.
—
Reply to this email directly, view it on GitHub
<#277 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARUHI35I3JQEI66GHDBKRTXXBSFFANCNFSM6AAAAAA35BJTM4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
planger
approved these changes
Aug 25, 2023
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Aug 26, 2023
Update Theia integration code to conform to latest client changes Requires eclipse-glsp/glsp-client#277
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Aug 26, 2023
Update Theia integration code to conform to latest client changes Requires eclipse-glsp/glsp-client#277
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Aug 26, 2023
Update Theia integration code to conform to latest client changes Requires eclipse-glsp/glsp-client#277
tortmayr
added a commit
to eclipse-glsp/glsp-theia-integration
that referenced
this pull request
Aug 26, 2023
Update Theia integration code to conform to latest client changes Requires eclipse-glsp/glsp-client#277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to sprotty 0.14.0 and adapt code to conform to latest changes/API breaks. With 0.14.0 the
ToolManager APIwas deprecated and it will be removed in future versions. The intention is that this API moves to GLSP as it is only used there => refactorToolManager APIFixes eclipse-glsp/glsp#1096
Fixes eclipse-glsp/glsp#1094 (via sprotty update)