Command Palette in 1.1.0.RC10 - wrong position of suggestion list? #1094
Assignees
Labels
Comments
|
This seems to be broken in sprotty as well. I think we pulled in this bug when upgrading to the latest sprotty version. |
|
@planger I provided a fix in sprotty for this: eclipse-sprotty/sprotty#372. |
|
Great, thank you @tortmayr! Already briefly tested and approved :-) |
tortmayr
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Aug 24, 2023
Update to sprotty 0.14.0 and adapt code to conform to latest changes/API breaks. With 0.14.0 the `ToolManager API` was deprecated and it will be removed in future versions. The intention is that this API moves to GLSP as it is only used there => refactor `ToolManager API` Fixes eclipse-glsp/glsp#1096 Fixes eclipse-glsp/glsp#1094
tortmayr
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Aug 25, 2023
Update to sprotty 0.14.0 and adapt code to conform to latest changes/API breaks. With 0.14.0 the `ToolManager API` was deprecated and it will be removed in future versions. The intention is that this API moves to GLSP as it is only used there => refactor `ToolManager API` GLSP-960: Make glspClient retrieval async Fixes eclipse-glsp/glsp#1096 Fixes eclipse-glsp/glsp#1094
tortmayr
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Aug 25, 2023
Update to sprotty 0.14.0 and adapt code to conform to latest changes/API breaks. With 0.14.0 the `ToolManager API` was deprecated and it will be removed in future versions. The intention is that this API moves to GLSP as it is only used there => refactor `ToolManager API` GLSP-960: Make glspClient retrieval async Fixes eclipse-glsp/glsp#1096 Fixes eclipse-glsp/glsp#1094
tortmayr
added a commit
to eclipse-glsp/glsp-client
that referenced
this issue
Aug 25, 2023
Update to sprotty 0.14.0 and adapt code to conform to latest changes/API breaks. With 0.14.0 the `ToolManager API` was deprecated and it will be removed in future versions. The intention is that this API moves to GLSP as it is only used there => refactor `ToolManager API` GLSP-960: Make glspClient retrieval async Fixes eclipse-glsp/glsp#1096 Fixes eclipse-glsp/glsp#1094
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Discussed in #1093
Originally posted by rsoika August 20, 2023
Hi,
something seems to have changed with the Command Palette from RC04 to RC10 with the
The command-palette-suggestions are now no longer placed relative to the command-palette-input. It seems the element is now positioned relative to the man window. If I change the left menue-bar than the command-palette-suggestions position also changed.
See:
I am not the expert in CSS but I think the problem is the attribute
position: absolute;assigned to the elementautocomplete command-palette-suggestionsIf I remove this attribute or change it tofixedit may propabyl work again correctly. But I can not really verifiy this as the component is constructed by some javascript dynamically.The text was updated successfully, but these errors were encountered: