Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure no inversify-based code lands in the index #384

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Ensure no inversify-based code lands in the index #384

merged 1 commit into from
Jul 25, 2024

Conversation

martin-fleck-at
Copy link
Contributor

What it does

  • Ensure JsonrpcClientProxy is injectable in the glsp-sprotty context

Contributed on behalf of Axon Ivy AG
Part of eclipse-glsp/glsp#1381

How to test

  • Create an npm package that depends on the GLSP protocol but do not specify inversify as a dependency. Everything should still work.

Follow-ups

Changelog

  • This PR should be mentioned in the changelog
  • This PR introduces a breaking change (if yes, provide more details below for the changelog and the migration guide)

@martin-fleck-at
Ensure no inversify-based code lands in the index
f97984f 
- Ensure JsonrpcClientProxy is injectable in the glsp-sprotty context

Contributed on behalf of Axon Ivy AG
Part of eclipse-glsp/glsp#1381
@martin-fleck-at martin-fleck-at requested a review from tortmayr July 25, 2024 13:00
This was referenced Jul 25, 2024
Merged
Closed
tortmayr
tortmayr approved these changes Jul 25, 2024
View reviewed changes
Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏼

@tortmayr tortmayr merged commit 8eb216c into master Jul 25, 2024
7 checks passed
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
@martin-fleck-at @holkerveen
Ensure no inversify-based code lands in the index (eclipse-glsp#384)
05901ad 
- Ensure JsonrpcClientProxy is injectable in the glsp-sprotty context

Contributed on behalf of Axon Ivy AG
Part of eclipse-glsp/glsp#1381
holkerveen pushed a commit to holkerveen/glsp-client that referenced this pull request Dec 21, 2024
@martin-fleck-at @holkerveen
Ensure no inversify-based code lands in the index (eclipse-glsp#384)
b6cf49e 
- Ensure JsonrpcClientProxy is injectable in the glsp-sprotty context

Contributed on behalf of Axon Ivy AG
Part of eclipse-glsp/glsp#1381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tortmayr tortmayr tortmayr approved these changes

Assignees
No one assigned
Labels
changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martin-fleck-at @tortmayr