Ensure JsonrpcClientProxy is injectable in the Theia context #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributed on behalf of Axon Ivy AG Part of eclipse-glsp/glsp#1381
martin-fleck-at
force-pushed
the
issues/1381
branch
from
dedf24f to
da5e00b
Compare
|
@tortmayr For some reasons there seem to be problems with the css files in the build, do you have any idea why? But more importantly, I think this PR is unnecessary because the glsp-theia-integration already relies on the client package which does the decoration of the class and we cannot decorate a class twice. Or do you see any problem I might overlook? |
|
You are right. This PR is obsolete and can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Contributed on behalf of Axon Ivy AG
Part of eclipse-glsp/glsp#1381
Requires eclipse-glsp/glsp-client#384
How to test
Follow-ups
Changelog