#712 Align GGraph model with newest changes from glsp-server #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndoschek
force-pushed
the
issues/712
branch
2 times, most recently
from
bc11317 to
86b5083
Compare
tortmayr
requested changes
Jul 15, 2022
- Align model in packages/graph with GGraph/SGraph - Add missing interface GHtmlRoot - Add missing static builder function for GIssueMarker - Rename files to match class/interface name - Update build scripts and VSCode build task - Update CHANGELOG Resolves eclipse-glsp/glsp#712 Contributed on behalf of STMicroelectronics.
|
Thanks @tortmayr for your review, I updated my commit, would be great if you could have another look thanks! |
tortmayr
approved these changes
Jul 15, 2022
tortmayr
reviewed
Jul 15, 2022
CHANGELOG.md
Outdated
| - `GLayoutContainer` (`glayout-container.ts`) -> `GLayouting` (`glayouting.ts`) (affected classes: `GCompartment`, `GGraph`, `GNode`) | ||
| - `GShapePreRenderedElement` (`gpre-shape-prerendered-element.ts`) -> `GShapedPreRenderedElement` (`gshaped-prerendered-element.ts`) | ||
| - Renamed file names: `gbound-aware.ts` -> `gbounds-aware.ts` | ||
| - `GGraph` now additionally extends `GLayoutable` |
There was a problem hiding this comment.
API additions don' need to be mentioned in the breaking change section (as they don't break any existing API 😉)
Please remove the last three lines
CHANGELOG.md
Outdated
| - [graph] Align GGraph model with newest changes from glsp-server [#22](https://github.com/eclipse-glsp/glsp-server-node/pull/22) - Contributed on behalf of STMicroelectronics | ||
| - Renamed interfaces: | ||
| - `EdgePlacement` -> `GEdgePlacement` (affected classes: `GEdgeLayoutable`, `GLabel`) | ||
| - `GLayoutContainer` (`glayout-container.ts`) -> `GLayouting` (`glayouting.ts`) (affected classes: `GCompartment`, `GGraph`, `GNode`) |
There was a problem hiding this comment.
You can omit the file information here ('glayout-container.ts`) etc. GLayoutContainer is default exported so a source file name changes does not break anything for adopters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves eclipse-glsp/glsp#712
Contributed on behalf of STMicroelectronics.