Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align GGraph model with newest changes from glsp-server #712

Closed
ndoschek opened this issue Jul 14, 2022 · 0 comments · Fixed by eclipse-glsp/glsp-server-node#22
Closed
Assignees
Labels
enhancement New feature or request server-node

Comments

@ndoschek
Copy link
Contributor

Follow-up of #694
See glsp-server PR eclipse-glsp/glsp-server#175

@ndoschek ndoschek added enhancement New feature or request server-node labels Jul 14, 2022
@ndoschek ndoschek self-assigned this Jul 14, 2022
@ndoschek ndoschek changed the title Add Layoutable interface Align GGraph model with newest changes from glsp-server Jul 14, 2022
ndoschek added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jul 14, 2022
- Align model in packages/graph with GGraph model from Java `glsp-server`
  - Add missing interfaces GArgumentable, GHtmlRoot
  - Align interfaces/class to GGraph model and implement missing interfaces
  - Change several parameters to optional parameters
  - Add missing static builder function for GIssue and GIssueMarker
  - Extract GIssue into separate file
  - Rename files to match class/interface name
  - Extends defaultTypeMappings
- Update VSCode build task
- Remove duplicate build step in yarn all script

Resolves eclipse-glsp/glsp#712

Contributed on behalf of STMicroelectronics.
ndoschek added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jul 15, 2022
- Align model in packages/graph with GGraph model from Java `glsp-server`
  - Add missing interfaces GArgumentable, GHtmlRoot
  - Align interfaces/class to GGraph/SGraph model and implement missing interfaces
  - Add missing static builder function for GIssue and GIssueMarker
  - Extract GIssue into separate file
  - Rename files to match class/interface name
  - Extends defaultTypeMappings
- Update VSCode build task
- Remove duplicate build step in yarn all script
- Update CHANGELOG
- Update markdownlint settings to allow heading duplication for non-sibling headings (common in changelogs), see also https://github.com/DavidAnson/markdownlint/blob/v0.25.1/doc/Rules.md#md024

Resolves eclipse-glsp/glsp#712

Contributed on behalf of STMicroelectronics.
ndoschek added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jul 15, 2022
- Align model in packages/graph with GGraph/SGraph
  - Add missing interface GHtmlRoot
  - Add missing static builder function for GIssueMarker
  - Rename files to match class/interface name
- Update build scripts and VSCode build task
- Update CHANGELOG

Resolves eclipse-glsp/glsp#712

Contributed on behalf of STMicroelectronics.
ndoschek added a commit to eclipse-glsp/glsp-server-node that referenced this issue Jul 15, 2022
* #712 Align GGraph model with newest changes from glsp-server

- Align model in packages/graph with GGraph/SGraph
  - Add missing interface GHtmlRoot
  - Add missing static builder function for GIssueMarker
  - Rename files to match class/interface name
- Update build scripts and VSCode build task
- Update CHANGELOG

Resolves eclipse-glsp/glsp#712

Contributed on behalf of STMicroelectronics.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request server-node
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant