Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS regression bug in Theia integration #1062

Closed
tortmayr opened this issue Jul 19, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-theia-integration#171
Closed

CSS regression bug in Theia integration #1062

tortmayr opened this issue Jul 19, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-theia-integration#171
Labels
bug Something isn't working theia

Comments

@tortmayr
Copy link
Contributor

With the #847 we introduced a regression css regression bug. The sprotty-theia.css style sheet is loaded after the theia-integration specific customizations and overrides some of the rules defined there. As a consequence some styles are not applied as expected.
E.g. The hover popup styling is wrong:

Peek 2023-07-19 12-12

While we are at it we should probably merge the sprotty-theia.css into the diagram.css stylesheet.
@tortmayr tortmayr added bug Something isn't working theia labels Jul 19, 2023
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jul 19, 2023
@tortmayr
GLSP-1062: Merge diagram & sproty-theia.css
4bb28f5 
Remove `sprotty-theia` stylesheet and merges styles into `diagram.css`
Also remove import of `sprotty.css` as this is already imported in glsp-client
Fixes eclipse-glsp/glsp#1062
@tortmayr tortmayr mentioned this issue Jul 19, 2023
Merged
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Jul 19, 2023
@tortmayr
GLSP-1062: Merge diagram & sproty-theia.css (#171)
43cd793 
Remove `sprotty-theia` stylesheet and merges styles into `diagram.css`
Also remove import of `sprotty.css` as this is already imported in glsp-client
Fixes eclipse-glsp/glsp#1062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working theia
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GLSP-1062: Merge diagram & sproty-theia.css eclipse-glsp/glsp-theia-integration
1 participant
@tortmayr