Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dependency to sprotty-theia #847

Closed
tortmayr opened this issue Jan 5, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-theia-integration#149
Closed

Drop dependency to sprotty-theia #847

tortmayr opened this issue Jan 5, 2023 · 0 comments · Fixed by eclipse-glsp/glsp-theia-integration#149
Assignees
@tortmayr
Labels
breaking enhancement New feature or request theia
Milestone
2.0.0 Release

Comments

@tortmayr
Copy link
Contributor

tortmayr commented Jan 5, 2023

Reasons:

  • GLSP Theia integration has been evolved beyond the intial scope the sprotty-theia integration. In many places we have to heavily customize the original API components. In other places, it prevents us from using new concepts. e.g. we want to get rid of the sprotty-theia connector class but this is currently not possible because it its a core concept of sprotty-theia's API
  • Effectively no longer maintained. Sprotty has shifted to sprotty-vscode for integration of sprotty diagrams in Theia. At the moment GLSP is the only active contributor to sprotty-theia.
  • yet another unnecessary indireciton. In many cases just the type definition is living in sprotty-theia and the actual implementation lives in glsp
  • We only need a subset of the sprotty-theia API

So we should drop the dependency to sprotty-theia and should maintain API concepts that we need (or a replacement for them) in-repo
@tortmayr tortmayr added enhancement New feature or request breaking labels Jan 5, 2023
@tortmayr tortmayr added this to the 2.0.0 Release milestone Jan 5, 2023
@tortmayr tortmayr added the theia label Jan 5, 2023
@tortmayr tortmayr mentioned this issue Jan 5, 2023
Closed
@tortmayr tortmayr self-assigned this Jan 18, 2023
@tortmayr tortmayr mentioned this issue Jan 31, 2023
Closed
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 11, 2023
@tortmayr
GLSP-847 Drop dependency to sprotty-theia
2bfc0dc 
Drop dependency to sprotty-theia , move dependent code in-repo and adapt existing code base.
Code that is adapted from the orginal sprotty-theia repository is proplery marked in the copyright notice and with an inline comment

Depends on: #146
Fixes eclipse-glsp/glsp#847
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 11, 2023
@tortmayr
GLSP-847 Drop dependency to sprotty-theia
5391791 
Drop dependency to sprotty-theia , move dependent code in-repo and adapt existing code base.
Code that is adapted from the orginal sprotty-theia repository is proplery marked in the copyright notice and with an inline comment

Depends on: #146
Fixes eclipse-glsp/glsp#847
@tortmayr tortmayr mentioned this issue Mar 11, 2023
Merged
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 15, 2023
@tortmayr
GLSP-847 Drop dependency to sprotty-theia
c603968 
Drop dependency to sprotty-theia , move dependent code in-repo and adapt existing code base.
Code that is adapted from the orginal sprotty-theia repository is proplery marked in the copyright notice and with an inline comment

Depends on: #146
Fixes eclipse-glsp/glsp#847
tortmayr added a commit to eclipse-glsp/glsp-theia-integration that referenced this issue Mar 16, 2023
@tortmayr
GLSP-847 Drop dependency to sprotty-theia (#149)
4fd7e64 
Drop dependency to sprotty-theia , move dependent code in-repo and adapt existing code base.
Code that is adapted from the orginal sprotty-theia repository is proplery marked in the copyright notice and with an inline comment

Depends on: #146
Fixes eclipse-glsp/glsp#847
@tortmayr tortmayr mentioned this issue Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tortmayr tortmayr

Labels
breaking enhancement New feature or request theia
Projects
None yet
Milestone
2.0.0 Release
Development

Successfully merging a pull request may close this issue.

GLSP-847 Drop dependency to sprotty-theia eclipse-glsp/glsp-theia-integration
1 participant
@tortmayr