New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Windows 10 support #33

Closed

7 tasks done

budrus opened this issue Jan 15, 2020 · 8 comments · Fixed by #682, #772, #797, #820 or #834

Closed

7 tasks done

Basic Windows 10 support #33

budrus opened this issue Jan 15, 2020 · 8 comments · Fixed by #682, #772, #797, #820 or #834

Assignees

Labels

Milestone

Contributor

budrus commented Jan 15, 2020 •

edited by elfenpiff

Loading

Brief feature description

Having the possibility to use iceoryx on Windows 10

Detailed information

Needed for ROS2 tier 1 support ROS2 Tiers

Unit and integration tests, except timing tests, of the supported features need to run on Windows
- remove define public private Remove #define private public from all tests #529
- all tests build and are green

The following features have to be implemented

Implement and integrate named pipes for IPC in windows
inter process capable mutex
inter process capable semaphore
use named ipc semaphore in named pipe

The text was updated successfully, but these errors were encountered:

mossmaurice added the enhancement label

rex-schilasky commented Feb 3, 2020

Highly welcomed by the eCAL project too.

Contributor

elfenpiff commented Feb 5, 2020

I am on it ...

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 adding stub functions so that windows at least…

08b9a07

… compiles; semaphore implemented

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 solved merge conflict with 32 bit branch

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 qnx in cmake

2fd3f0f

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 added static cast to help with template deduct…

4b1acc3

…ion; decltype in duration used for platform independent conversion; other windows platform tweaks

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 added un.hpp platform header for socket suppor…

99b5608

…t; some casting for mmap return value type deduction

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 removed some windows macros

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 removed some more macros

e50ce57

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 it compiles finally; added platform dependent …

…linking in cmake; adjusted smart_c calls since __PRETTY_FUNCTION__ works in windows only inside of functions; removed linux headers from windows platform files

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 added gtest downloading in windows cmake; adju…

69a9cd1

…sted some unit test dependencies in cmake

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 cmake unit test compile flags - multiplatform …

cfc78e0

…support; removed some gcc non c++ standard extensions; added stubs to platform

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 removed acl unit test for windows; introduced …

2edca8c

…workaround for msvc compiler since it seems to be broken with std::forward

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff added a commit to elfenpiff/iceoryx that referenced this issue


          iox-eclipse-iceoryx#33 resolved weird msvc unresolved external symbol…

7046c67

… problem with getMembers function

Signed-off-by: Christian Eltzschig <christian.eltzschig2@de.bosch.com>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Implement named pipes with send/receive semaphore

808ed79

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Rebase with current master

36c3c22

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff reopened this

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Add copyright header

98355e6

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Simplify semaphore creation

8e633d6

Restore cout/cerr/clog flags when changing

Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 removed unnecessary relative pointer from semaphore

3fba0a9

Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Use unnamed semaphores for named pipes

093fb6a

Signed-off-by: Christian Eltzschig <christian.eltzschig@apex.ai>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Cleanup code, remove deprecated semaphore ctor, privatize get…

a778413

…Handle in semaphore

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Wait until NamedPipe is initialized

9a16aea

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Simplify semaphore creation

4dd406b

Restore cout/cerr/clog flags when changing

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 removed unnecessary relative pointer from semaphore

04dd9ae

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Use unnamed semaphores for named pipes

8c6e0b9

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Cleanup code, remove deprecated semaphore ctor, privatize get…

0a8ae0b

…Handle in semaphore

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Wait until NamedPipe is initialized

22aece1

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Simplify semaphore creation

0693d54

Restore cout/cerr/clog flags when changing

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 removed unnecessary relative pointer from semaphore

77c97f2

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Use unnamed semaphores for named pipes

b6e812e

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Cleanup code, remove deprecated semaphore ctor, privatize get…

4d5543f

…Handle in semaphore

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Wait until NamedPipe is initialized

568a7af

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Removed unnecessary header

341dba5

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Fix clang linker issue with static constexpr member

23b6df3

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Cleaned up shm creation

c0a2272

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 NamedPipeData is only destroyed when NamedPipe has the ownership

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff referenced this issue in ApexAI/iceoryx


          iox-#33 Remove unused constants, clearify docu, use deadline timer

efa2a79

Signed-off-by: Christian Eltzschig <me@elchris.org>

elfenpiff closed this as completed in #847

elfenpiff added a commit that referenced this issue


          Merge pull request #847 from ApexAI/iox-#33-efficient-named-pipes-wit…

…h-semaphores

Iox #33 efficient named pipes with semaphores

Contributor

elfenpiff commented Jun 18, 2021

Basic Windows support is implemented. All examples are running and most of the unit tests too (except unix domain sockets or ACLs). The tests which are excluded at the moment are testing corner cases which are not relevant for the everyday use and will be implemented with #846

elBoberido mentioned this issue

Building 1.0 on Windows (MSVC 2019) #868

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment