Iox #33 disable warnings on windows #682
Merged
+30
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
elBoberido
requested review from
mossmaurice,
dkroenke,
budrus and
MatthiasKillat
Closed
7 tasks
dkroenke
previously approved these changes
Apr 6, 2021
mossmaurice
reviewed
Apr 6, 2021
| @@ -57,5 +58,5 @@ endif() | |||
| add_executable(${PROJECT_PREFIX}_moduletests ${MODULETESTS_SRC}) | |||
| set_property(TARGET ${PROJECT_PREFIX}_moduletests PROPERTY CXX_STANDARD ${ICEORYX_CXX_STANDARD}) | |||
| target_include_directories(${PROJECT_PREFIX}_moduletests PRIVATE .) | |||
| target_compile_options(${PROJECT_PREFIX}_moduletests PUBLIC -fPIC PRIVATE ${TEST_CXX_FLAGS}) | |||
| target_compile_options(${PROJECT_PREFIX}_moduletests PRIVATE ${TEST_CXX_FLAGS}) | |||
There was a problem hiding this comment.
We don't need a ``POSITION_INDEPENDENT_CODE ON` here as fPIC is only for lib builds?
There was a problem hiding this comment.
I think it's a leftover from a previous cleanup. It's not used anywhere else.
iceoryx_utils/test/stresstests/benchmark_optional_and_expected/CMakeLists.txt
Show resolved
Hide resolved
Signed-off-by: Mathias Kraus <mathias.kraus@apex.ai>
dkroenke
approved these changes
Apr 6, 2021
Codecov Report
@@ Coverage Diff @@
## release_1.0 #682 +/- ##
===============================================
- Coverage 74.54% 74.50% -0.05%
===============================================
Files 317 317
Lines 11217 11217
Branches 1969 1969
===============================================
- Hits 8362 8357 -5
- Misses 2078 2082 +4
- Partials 777 778 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mossmaurice
approved these changes
Apr 6, 2021
marthtz
pushed a commit
to boschglobal/iceoryx
that referenced
this pull request
May 12, 2021
…rnings-on-windows Iox eclipse-iceoryx#33 disable warnings on windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Review Checklist for the PR Author
iox-#123-this-is-a-branch)iox-#123 commit text)git commit -s)task-list-completed)Notes for Reviewer
The compiler warnings for MSVC are disabled. I also added a todo to #33 to re-enable them when Windows is fully supported.
Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References