Iox #27 create smart chunk

[elfenpiff]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

Creates SmartChunk, Request and Response according to: https://github.com/eclipse-iceoryx/iceoryx/blob/master/doc/design/request_response_communication.md

In the unit tests only the sample is tested since the Request/ResponseInterface are not yet available. When they become available the typed unit tests will be extended to support their types as well.

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
  • Each unit test case has a unique UUID
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Implements SmartChunk, Request and Response from Request/Response communication with iceoryx #27

[codecov]

Codecov Report

Merging #1081 (6efba45) into master (947a850) will increase coverage by 0.86%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1081      +/-   ##
==========================================
+ Coverage   76.10%   76.96%   +0.86%     
==========================================
  Files         344      346       +2     
  Lines       13030    13172     +142     
  Branches     1869     1885      +16     
==========================================
+ Hits         9916    10138     +222     
+ Misses       2496     2417      -79     
+ Partials      618      617       -1     

Flag	Coverage Δ
unittests	76.20% <100.00%> (+0.87%)	⬆️
unittests_timing	12.38% <0.00%> (-0.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...eoryx_posh/include/iceoryx_posh/popo/publisher.hpp	100.00% <ø> (ø)
...posh/include/iceoryx_posh/internal/popo/sample.inl	100.00% <100.00%> (+17.14%)	⬆️
...include/iceoryx_posh/internal/popo/smart_chunk.hpp	100.00% <100.00%> (ø)
...include/iceoryx_posh/internal/popo/smart_chunk.inl	100.00% <100.00%> (ø)
iceoryx_posh/source/popo/server_options.cpp	100.00% <0.00%> (ø)
...ceoryx_binding_c/source/cpp2c_enum_translation.cpp	100.00% <0.00%> (ø)
...oofs/include/iceoryx_hoofs/posix_wrapper/timer.hpp	100.00% <0.00%> (ø)
...include/iceoryx_posh/capro/service_description.hpp	100.00% <0.00%> (ø)
...osh/internal/popo/building_blocks/chunk_sender.hpp	100.00% <0.00%> (ø)
...oryx_posh/internal/popo/ports/server_port_user.inl	70.83% <0.00%> (ø)
... and 14 more

[elBoberido]

And there they are, the sins of the past. I should have used data instead of sample for the chunk mock

[elfenpiff]

This could be easy fixable. Should I rename it from sample to data in a separate PR?

[elBoberido]

If you like you can do. I'm not sure if it affects open PRs though.

[elBoberido]

Small nitpick. I guess this could be simplified to [&detectedError](const auto error, const auto&, const auto errorLevel) {

[elBoberido]

Was it intentional to use auto only for ErrorLevel?

[FerdinandSpitzschnueffler]

Please add unique ids to the tests.