iox #27 Sample class Refactoring

[Indra5196]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Relates to Request/Response communication with iceoryx #27

[codecov]

Codecov Report

Merging #871 (605f6db) into master (2685910) will decrease coverage by 0.02%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master     #871      +/-   ##
==========================================
- Coverage   75.62%   75.60%   -0.03%     
==========================================
  Files         335      337       +2     
  Lines       12219    12228       +9     
  Branches     2037     2037              
==========================================
+ Hits         9241     9245       +4     
- Misses       2194     2197       +3     
- Partials      784      786       +2     

Flag	Coverage Δ
unittests	74.52% <75.00%> (-0.01%)	⬇️
unittests_timing	29.72% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
iceoryx_posh/include/iceoryx_posh/popo/sample.hpp	66.66% <0.00%> (+9.52%)	⬆️
...ryx_posh/include/iceoryx_posh/popo/smart_chunk.hpp	57.14% <57.14%> (ø)
...include/iceoryx_posh/internal/popo/smart_chunk.inl	77.77% <77.77%> (ø)
...posh/include/iceoryx_posh/internal/popo/sample.inl	100.00% <100.00%> (+17.14%)	⬆️
iceoryx_hoofs/source/concurrent/loffli.cpp	85.29% <0.00%> (-5.89%)	⬇️
iceoryx_hoofs/source/posix_wrapper/timer.cpp	60.60% <0.00%> (-0.87%)	⬇️

[elBoberido]

Please replace Closes TBD with Relates to #27 in order to link this PR to the issue.

Please also add tests for Request and Response similar to what is tested in test_popo_sample.cpp

[elBoberido]

I think once you create a test for this class, this won't compile since there is no RpcInterface defined anywhere.

Also, at some places you use RcpInterface<T> which is passed to Base_t which has a RpcInterface<Request<T>>.

Could you please create some tests like in test_popo_sample.cpp but for Request and Response

[elBoberido]

oh, I just noticed that there is a rpc_interface.hpp added in #881. Please add it in this PR

[elBoberido]

please use cxx::add_const_conditionally_t similar to what is done with the ChunkHeader to make this const in case T has the const qualifier

[elBoberido]

same here

[elBoberido]

@Indra5196 just want to check the status of this PR. Are you working on the tests or are you waiting for some feedback from me?

[elBoberido]

Closed in favor of #1081