Iox #27 add untyped client and server api [stacked PR #4]

[elBoberido]

Pre-Review Checklist for the PR Author

1. Code follows the coding style of CONTRIBUTING.md
2. Tests follow the best practice for testing
3. Changelog updated in the unreleased section including API breaking changes
4. Branch follows the naming format (iox-#123-this-is-a-branch)
5. Commits messages are according to this guideline
   • Commit messages have the issue ID (iox-#123 commit text)
   • Commit messages are signed (git commit -s)
   • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
6. Update the PR title
   • Follow the same conventions as for commit messages
   • Link to the relevant issue
7. Relevant issues are linked
8. Add sensible notes for the reviewer
9. All checks have passed (except task-list-completed)
10. Assign PR to reviewer

Notes for Reviewer

This PR add the untyped API for the Client and Server. The functionality is complete.

The changelog will be updated once the feature is finished.

Test will be added in PR #1138

Checklist for the PR Reviewer

• Commits are properly organized and messages are according to the guideline
• Code according to our coding style and naming conventions
• Unit tests have been written for new behavior
  • Each unit test case has a unique UUID
• Public API changes are documented via doxygen
• Copyright owner are updated in the changed files
• PR title describes the changes

Post-review Checklist for the PR Author

1. All open points are addressed and tracked via issues

References

• Relates to Request/Response communication with iceoryx #27

[elfenpiff]

Could you please add nullptr tests for the methods which have a pointer argument and where there is a potential segfault hidden.
For those methods which also return a pointer I would return a nullptr when they are called with a nullptr then we would be at least consistent with the remaining code base.

[elfenpiff]

Wouldn't it be better to return here const capro::ServiceDescription & . After creation it should not change anymore or do we run then into consistency issues with the other ports?

[elBoberido]

I also think it is save to return a reference. Shall I also change it for the publisher and subscriber?

[budrus]

Nice reading

[codecov]

Codecov Report

Merging #1091 (af45306) into master (8f7fc7f) will decrease coverage by 0.07%.
The diff coverage is 26.92%.

@@            Coverage Diff             @@
##           master    #1091      +/-   ##
==========================================
- Coverage   76.29%   76.21%   -0.08%     
==========================================
  Files         346      346              
  Lines       13585    13603      +18     
  Branches     1935     1939       +4     
==========================================
+ Hits        10364    10367       +3     
- Misses       2589     2607      +18     
+ Partials      632      629       -3     

Flag	Coverage Δ
unittests	75.46% <26.92%> (-0.09%)	⬇️
unittests_timing	12.00% <0.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ude/iceoryx_posh/internal/popo/ports/base_port.hpp	100.00% <ø> (ø)
...oryx_posh/internal/popo/ports/client_port_user.hpp	100.00% <ø> (ø)
...oryx_posh/internal/popo/ports/server_port_user.hpp	100.00% <ø> (ø)
iceoryx_posh/source/popo/rpc_header.cpp	75.51% <0.00%> (-24.49%)	⬇️
...ceoryx_posh/source/popo/ports/client_port_user.cpp	92.30% <40.00%> (-4.47%)	⬇️
...ceoryx_posh/source/popo/ports/server_port_user.cpp	96.38% <50.00%> (-3.62%)	⬇️
iceoryx_posh/source/popo/ports/base_port.cpp	88.46% <66.66%> (ø)
iceoryx_hoofs/source/posix_wrapper/timer.cpp	63.48% <0.00%> (+0.41%)	⬆️
...nternal/relocatable_pointer/pointer_repository.inl	88.63% <0.00%> (+2.27%)	⬆️
iceoryx_hoofs/source/concurrent/loffli.cpp	91.42% <0.00%> (+2.85%)	⬆️