Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iox #27 add untyped client and server api [stacked PR #4] #1091

Merged
merged 17 commits into from
Feb 21, 2022
Merged

Iox #27 add untyped client and server api [stacked PR #4] #1091

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
be820a6
iox-#27 Add releaseQueuedResponses to client port
elBoberido Feb 10, 2022
cbcf8f2
iox-#27 Add BaseClient for typed and untyped API
elBoberido Feb 10, 2022
404c36d
iox-#27 Add releaseQueuedRequests to server port
elBoberido Feb 10, 2022
a437204
iox-#27 Add BaseServer for typed and untyped API
elBoberido Feb 10, 2022
1ccd66f
iox-#27 Add UntypedClient and UntypedClientImpl
elBoberido Feb 11, 2022
3a21612
iox-#27 Add UntypedServer and UntypedServerImpl
elBoberido Feb 11, 2022
fc1011b
iox-#27 Add convenience 'fromPayload' static function to RequestHeade…
elBoberido Feb 14, 2022
db0480e
iox-#27 Rename freeRequest/freeResponse to releaseRequest/releaseResp…
elBoberido Feb 14, 2022
7306abe
iox-#27 Remove default ctors for BaseClient and BaseServer
elBoberido Feb 15, 2022
1494449
iox-#27 Return reference to ServiceDescription instead of copy
elBoberido Feb 18, 2022
c98ddbc
iox-#27 Update documentation
elBoberido Feb 18, 2022
681792a
iox-#27 Add nullptr checks
elBoberido Feb 18, 2022
1f520cd
iox-#27 Add const
elBoberido Feb 18, 2022
e56a5f0
iox-#27 Update documentation
elBoberido Feb 18, 2022
facc658
iox-#27 Delete copy/move ctor/assignmen operator for untyped client a…
elBoberido Feb 18, 2022
432dd56
iox-#27 Do not initialize ClientPortUser and ServerPortUser with null…
elBoberido Feb 21, 2022
af45306
iox-#27 Return const references in BasePort
elBoberido Feb 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion doc/design/diagrams/request_response/client_port.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ class ClientPortUser {
getConnectionState(): ConnectionState
allocateRequest(userPayloadSize: uint32_t, userPayloadAlignment: uint32_t): expected<RequestHeader*, AllocationError>
sendRequest(requestHeader: RequestHeader*): void
freeRequest(requestHeader: RequestHeader*): void
releaseRequest(requestHeader: const RequestHeader*): void
getResponse(): expected<const ResponseHeader*, ChunkReceiveResult>
releaseResponse(responseHeader: const ResponseHeader*): void
hasNewResponses(): void
Expand Down
2 changes: 1 addition & 1 deletion doc/design/diagrams/request_response/server_port.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class ServerPortUser {
hasLostRequestsSinceLastCall(): bool
allocateResponse(requestHeader: RequestHeader*, userPayloadSize: uint32_t, userPayloadAlignment: uint32_t): expected<ResponseHeader*, AllocationError>
sendResponse(responseHeader: ResponseHeader*): void
freeResponse(responseHeader: ResponseHeader*): void
releaseResponse(responseHeader: const ResponseHeader*): void
setConditionVariable(conditionVariable: ConditionVariableData&, notificationIndex: uint64_t): void
unsetConditionVariable: void
isConditionVariableSet(): bool
Expand Down
12 changes: 6 additions & 6 deletions doc/design/diagrams/request_response/untyped_api.puml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ class UntypedClient {
disconnect(): void
getConnectionState(): ConnectionState
loan(userPayloadSize: uint32_t, userPayloadAlignment: uint32_t): expected<void*, Error>
send(request: void*): void
release(request: void*): void
send(requestPayload: void*): void
releaseRequest(requestPayload: const void*): void
hasResponses(): bool
take(): expected<void*, Error>
release(response: void*): void
releaseResponse(responsePayload: void*): void
releaseQueuedResponses(): void
hasMissedResponses(): bool
}
Expand All @@ -23,12 +23,12 @@ class UntypedServer {
hasClients(): bool
hasRequests(): bool
take(): expected<void*, Error>
release(request: void*): void
releaseRequest(requestPayload: void*): void
releaseQueuedRequests(): void
hasMissedRequests(): bool
loan(requestHeader: RequestHeader*, userPayloadSize: uint32_t, userPayloadAlignment: uint32_t): expected<void*, Error>
send(response: void*): void
release(response: void*): void
send(responsePayload: void*): void
releaseResponse(responsePayload: const void*): void
}

@enduml
8 changes: 4 additions & 4 deletions doc/website/images/client_port.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 7 additions & 6 deletions doc/website/images/server_port.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
6 changes: 3 additions & 3 deletions doc/website/images/untyped_api.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 4 additions & 0 deletions iceoryx_hoofs/include/iceoryx_hoofs/error_handling/error_handling.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ namespace iox
error(POSH__SERVICE_DISCOVERY_INSTANCE_CONTAINER_OVERFLOW) \
error(POPO__BASE_SUBSCRIBER_OVERRIDING_WITH_EVENT_SINCE_HAS_DATA_OR_DATA_RECEIVED_ALREADY_ATTACHED) \
error(POPO__BASE_SUBSCRIBER_OVERRIDING_WITH_STATE_SINCE_HAS_DATA_OR_DATA_RECEIVED_ALREADY_ATTACHED) \
error(POPO__BASE_CLIENT_OVERRIDING_WITH_EVENT_SINCE_HAS_RESPONSE_OR_RESPONSE_RECEIVED_ALREADY_ATTACHED) \
budrus marked this conversation as resolved.
Show resolved Hide resolved
error(POPO__BASE_CLIENT_OVERRIDING_WITH_STATE_SINCE_HAS_RESPONSE_OR_RESPONSE_RECEIVED_ALREADY_ATTACHED) \
error(POPO__BASE_SERVER_OVERRIDING_WITH_EVENT_SINCE_HAS_REQUEST_OR_REQUEST_RECEIVED_ALREADY_ATTACHED) \
error(POPO__BASE_SERVER_OVERRIDING_WITH_STATE_SINCE_HAS_REQUEST_OR_REQUEST_RECEIVED_ALREADY_ATTACHED) \
error(POPO__CHUNK_QUEUE_POPPER_CHUNK_WITH_INCOMPATIBLE_CHUNK_HEADER_VERSION) \
error(POPO__CHUNK_DISTRIBUTOR_OVERFLOW_OF_QUEUE_CONTAINER) \
error(POPO__CHUNK_DISTRIBUTOR_CLEANUP_DEADLOCK_BECAUSE_BAD_APPLICATION_TERMINATION) \
Expand Down
Loading