Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1580 Disable monitoring feature in RouDi by default #1584

Conversation

mossmaurice
Copy link
Contributor

@mossmaurice mossmaurice commented Aug 17, 2022

Pre-Review Checklist for the PR Author

  1. Code follows the coding style of CONTRIBUTING.md
  2. Tests follow the best practice for testing
  3. Changelog updated in the unreleased section including API breaking changes
  4. Branch follows the naming format (iox-123-this-is-a-branch)
  5. Commits messages are according to this guideline
    • Commit messages have the issue ID (iox-#123 commit text)
    • Commit messages are signed (git commit -s)
    • Commit author matches Eclipse Contributor Agreement (and ECA is signed)
  6. Update the PR title
    • Follow the same conventions as for commit messages
    • Link to the relevant issue
  7. Relevant issues are linked
  8. Add sensible notes for the reviewer
  9. All checks have passed (except task-list-completed)
  10. All touched (C/C++) source code files are added to ./clang-tidy-diff-scans.txt not done for posh
  11. Assign PR to reviewer

Notes for Reviewer

  • Disable monitoring feature in RouDi by default

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Code according to our coding style and naming conventions
  • Unit tests have been written for new behavior
  • Public API changes are documented via doxygen
  • Copyright owner are updated in the changed files
  • [ ] All touched (C/C++) source code files have been added to ./clang-tidy-diff-scans.txt
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
…ehaviour of the monitoring feature in RouDi

Signed-off-by: Simon Hoinkis <simon.hoinkis@apex.ai>
@mossmaurice mossmaurice added the refactoring Refactor code without adding features label Aug 17, 2022
@mossmaurice mossmaurice requested review from dkroenke and budrus August 17, 2022 17:23
@mossmaurice mossmaurice self-assigned this Aug 17, 2022
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #1584 (edfd23d) into master (d2dd5b2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1584      +/-   ##
==========================================
- Coverage   76.37%   76.35%   -0.03%     
==========================================
  Files         360      360              
  Lines       13865    13865              
  Branches     1941     1941              
==========================================
- Hits        10590    10587       -3     
- Misses       2702     2703       +1     
- Partials      573      575       +2     
Flag Coverage Δ
unittests 76.00% <100.00%> (-0.03%) ⬇️
unittests_timing 15.59% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
..._posh/include/iceoryx_posh/roudi/cmd_line_args.hpp 81.81% <ø> (ø)
...clude/iceoryx_posh/roudi/roudi_cmd_line_parser.hpp 100.00% <ø> (ø)
...ceoryx_posh/source/roudi/roudi_cmd_line_parser.cpp 100.00% <100.00%> (ø)
iceoryx_hoofs/source/concurrent/loffli.cpp 85.71% <0.00%> (-5.72%) ⬇️
iceoryx_posh/source/roudi/port_manager.cpp 84.24% <0.00%> (-0.19%) ⬇️

@mossmaurice mossmaurice merged commit 41a5725 into eclipse-iceoryx:master Aug 19, 2022
@mossmaurice mossmaurice deleted the iox-#1580-disable-monitoring-feature-by-default branch August 19, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactor code without adding features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled monitoring feature in RouDi by default
3 participants