Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iox-#1580 Disable monitoring feature in RouDi by default #1584

Merged
merged 3 commits into from
Aug 19, 2022
Merged

iox-#1580 Disable monitoring feature in RouDi by default #1584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17bcb61
iox-#1580 Disable monitoring feature by default
mossmaurice Aug 17, 2022
894e8e1
iox-#1580 Adapt tests for new default settings of RouDi
mossmaurice Aug 17, 2022
edfd23d
iox-#1580 Add release note entry for changed default behaviour of the…
mossmaurice Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/website/release-notes/iceoryx-unreleased.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@
- Cleanup helplets [\#1560](https://github.com/eclipse-iceoryx/iceoryx/issues/1560)
- Moved package `iceoryx_dds` to [separate repository](https://github.com/eclipse-iceoryx/iceoryx-gateway-dds) [\#1564](https://github.com/eclipse-iceoryx/iceoryx/issues/1564)
- Set `SOVERSION` with project major version for shared libraries in CMake [\#1308](https://github.com/eclipse-iceoryx/iceoryx/issues/1308)
- Monitoring feature of RouDi is now disabled by default [\#1580](https://github.com/eclipse-iceoryx/iceoryx/issues/1580)

**Workflow:**

Expand Down
2 changes: 1 addition & 1 deletion iceoryx_posh/include/iceoryx_posh/roudi/cmd_line_args.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ namespace config
{
struct CmdLineArgs_t
{
roudi::MonitoringMode monitoringMode{roudi::MonitoringMode::ON};
roudi::MonitoringMode monitoringMode{roudi::MonitoringMode::OFF};
iox::log::LogLevel logLevel{iox::log::LogLevel::kWarn};
version::CompatibilityCheckLevel compatibilityCheckLevel{version::CompatibilityCheckLevel::PATCH};
units::Duration processKillDelay{roudi::PROCESS_DEFAULT_KILL_DELAY};
Expand Down
2 changes: 1 addition & 1 deletion iceoryx_posh/include/iceoryx_posh/roudi/roudi_cmd_line_parser.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class CmdLineParser
protected:
bool m_run{true};
iox::log::LogLevel m_logLevel{iox::log::LogLevel::kWarn};
roudi::MonitoringMode m_monitoringMode{roudi::MonitoringMode::ON};
roudi::MonitoringMode m_monitoringMode{roudi::MonitoringMode::OFF};
version::CompatibilityCheckLevel m_compatibilityCheckLevel{version::CompatibilityCheckLevel::PATCH};
cxx::optional<uint16_t> m_uniqueRouDiId;
units::Duration m_processKillDelay{roudi::PROCESS_DEFAULT_KILL_DELAY};
Expand Down
2 changes: 1 addition & 1 deletion iceoryx_posh/source/roudi/roudi_cmd_line_parser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ CmdLineParser::parse(int argc, char* argv[], const CmdLineArgumentParsingMode cm
std::cout << "-u, --unique-roudi-id <INT> Set the unique RouDi id." << std::endl;
std::cout << "-m, --monitoring-mode <MODE> Set process alive monitoring mode." << std::endl;
std::cout << " <MODE> {on, off}" << std::endl;
std::cout << " default = 'on'" << std::endl;
std::cout << " default = 'off'" << std::endl;
std::cout << " on: enables monitoring for all processes" << std::endl;
std::cout << " off: disables monitoring for all processes" << std::endl;
std::cout << "-l, --log-level <LEVEL> Set log level." << std::endl;
Expand Down
2 changes: 1 addition & 1 deletion iceoryx_posh/test/moduletests/test_roudi_iceoryx_roudi_app.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ TEST_F(IceoryxRoudiApp_test, VerifyConstructorIsSuccessful)

EXPECT_TRUE(roudi.getVariableRun());
EXPECT_EQ(roudi.getLogLevel(), iox::log::LogLevel::kWarn);
EXPECT_EQ(roudi.getMonitoringMode(), roudi::MonitoringMode::ON);
EXPECT_EQ(roudi.getMonitoringMode(), roudi::MonitoringMode::OFF);
}

TEST_F(IceoryxRoudiApp_test, CreateTwoRoudiAppIsSuccessful)
Expand Down