Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubernetesBuildTask: k8sBuild Generator - Quarkus #1047

Closed
2 tasks done
manusa opened this issue Oct 20, 2021 · 1 comment · Fixed by #1187
Closed
2 tasks done

KubernetesBuildTask: k8sBuild Generator - Quarkus #1047

manusa opened this issue Oct 20, 2021 · 1 comment · Fixed by #1187
Assignees
@sunix
Labels
component/gradle-plugin Related to the Gradle Plugins

Comments

@manusa
Copy link
Member

manusa commented Oct 20, 2021 •
edited
Loading

Description

Child of #31

k8sBuild Gradle task works with Quarkus Generator.

  • Any configuration setting should be part of the KubernetesExtension class (Tasks should have no Inputs)
  • Any logic present in the current Mojos should be moved to JKube-kit

AC
@manusa manusa added the component/gradle-plugin Related to the Gradle Plugins label Oct 20, 2021
This was referenced Oct 20, 2021
Open
Closed
@sunix sunix mentioned this issue Dec 2, 2021
Open
sunix added a commit to sunix/jkube that referenced this issue Dec 6, 2021
@sunix
fix: gradle image build should use the Quarkus generator for Quarkus …
e30a7d1 
…projects eclipse-jkube#1047

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>
@sunix sunix mentioned this issue Dec 6, 2021
Merged
12 tasks
sunix added a commit to sunix/jkube that referenced this issue Dec 6, 2021
@sunix
fix: gradle image build should use the Quarkus generator for Quarkus …
6520838 
…projects eclipse-jkube#1047

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>
@manusa manusa linked a pull request Dec 9, 2021 that will close this issue
fix: gradle image build should use the Quarkus generator for Quarkus projects #1047 #1163
Merged
12 tasks
@manusa manusa removed a link to a pull request Dec 9, 2021
fix: gradle image build should use the Quarkus generator for Quarkus projects #1047 #1163
Merged
12 tasks
manusa pushed a commit that referenced this issue Dec 9, 2021
@sunix @manusa
fix: gradle image build should use the Quarkus generator for Quarkus …
29372fd 
…projects #1047

Signed-off-by: Sun Seng David TAN <sutan@redhat.com>
@manusa
Copy link
Member Author

manusa commented Dec 9, 2021

We still need to add Generator related documentation, I don't know where we reflected this in #850.
Currently, we don't have any docs about Generators on the Gradle documentation.

@manusa manusa closed this as completed Jan 12, 2022
@manusa manusa mentioned this issue Jan 25, 2022
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunix sunix

Labels
component/gradle-plugin Related to the Gradle Plugins
Projects
None yet
Milestone
No milestone
2 participants
@manusa @sunix