Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubernetesBuildTask: k8sBuild Generator - SpringBoot #850

Closed
2 tasks done
manusa opened this issue Aug 12, 2021 · 0 comments · Fixed by #864
Closed
2 tasks done

KubernetesBuildTask: k8sBuild Generator - SpringBoot #850

manusa opened this issue Aug 12, 2021 · 0 comments · Fixed by #864
Assignees
@rohanKanojia
Labels
component/gradle-plugin Related to the Gradle Plugins
Milestone
1.5.0

Comments

@manusa
Copy link
Member

manusa commented Aug 12, 2021 •
edited
Loading

Description

Child of #31

k8sBuild Gradle task works with SpringBoot Generator.

  • Any configuration setting should be part of the KubernetesExtension class (Tasks should have no Inputs)
  • Any logic present in the current Mojos should be moved to JKube-kit

AC

  • Generator configuration options can be overridden via DSL
  • Port Sprint Boot related examples (compatible with the available goals): spring-boot, spring-boot-camel-complete, spring-boot-crd, spring-boot-with-jib
@manusa manusa added the component/gradle-plugin Related to the Gradle Plugins label Aug 12, 2021
@manusa manusa mentioned this issue Aug 12, 2021
Open
16 tasks
@manusa manusa changed the title KubernetesBuildTask k8sBuild: Generator - SpringBoot KubernetesBuildTask: k8sBuild Generator - SpringBoot Aug 12, 2021
@rohanKanojia rohanKanojia self-assigned this Aug 25, 2021
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 25, 2021
@rohanKanojia
Add outputArtifactDir to JavaProject
1fd6e78 
Gradle's build directory doesn't contain jar files unlike maven.
Adding an additional field outputArtifactDir which will store parent
directory of artifact file.

JavaExecGenerator would make use of outputArtifactDir field in order to
look for fat jars and creating AssemblyFileSets

Related to eclipse-jkube#850

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Aug 25, 2021
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 25, 2021
@rohanKanojia
Fix eclipse-jkube#850: SpringBootGenerator now generates ImageConfigu…
cc6f497 
…ration with gradle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Aug 25, 2021
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Aug 26, 2021
@rohanKanojia
Fix eclipse-jkube#850: SpringBootGenerator now generates ImageConfigu…
63d9ad4 
…ration with gradle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 1, 2021
@rohanKanojia
Add outputArtifactDir to JavaProject
6fdfb42 
Gradle's build directory doesn't contain jar files unlike maven.
Adding an additional field outputArtifactDir which will store parent
directory of artifact file.

JavaExecGenerator would make use of outputArtifactDir field in order to
look for fat jars and creating AssemblyFileSets

Related to eclipse-jkube#850

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit to rohanKanojia/jkube that referenced this issue Sep 1, 2021
@rohanKanojia @manusa
Add outputArtifactDir to JavaProject
3570c4f 
Gradle's build directory doesn't contain jar files unlike maven.
Adding an additional field outputArtifactDir which will store parent
directory of artifact file.

JavaExecGenerator would make use of outputArtifactDir field in order to
look for fat jars and creating AssemblyFileSets

Related to eclipse-jkube#850

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Sep 1, 2021
@rohanKanojia @manusa
Add outputArtifactDir to JavaProject
85f507e 
Gradle's build directory doesn't contain jar files unlike maven.
Adding an additional field outputArtifactDir which will store parent
directory of artifact file.

JavaExecGenerator would make use of outputArtifactDir field in order to
look for fat jars and creating AssemblyFileSets

Related to #850

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 2, 2021
@rohanKanojia
Fix eclipse-jkube#850: SpringBootGenerator now generates ImageConfigu…
ce41b76 
…ration with gradle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 6, 2021
@rohanKanojia
Fix eclipse-jkube#850: SpringBootGenerator now generates ImageConfigu…
9690294 
…ration with gradle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 6, 2021
@rohanKanojia
Fix eclipse-jkube#850: SpringBootGenerator now generates ImageConfigu…
b550ffc 
…ration with gradle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa linked a pull request Sep 8, 2021 that will close this issue
Fix #850: SpringBootGenerator now generates ImageConfiguration with gradle #864
Merged
12 tasks
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Sep 8, 2021
@rohanKanojia
Fix eclipse-jkube#850: SpringBootGenerator now generates ImageConfigu…
1834bcb 
…ration with gradle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Sep 10, 2021
@rohanKanojia @manusa
Fix #850: SpringBootGenerator now generates ImageConfiguration with g…
25d573d 
…radle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa closed this as completed Sep 10, 2021
@manusa manusa mentioned this issue Sep 10, 2021
Closed
manusa pushed a commit that referenced this issue Sep 16, 2021
@rohanKanojia @manusa
Fix #850: SpringBootGenerator now generates ImageConfiguration with g…
ac5d2e3 
…radle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Oct 11, 2021
@rohanKanojia @manusa
Fix #850: SpringBootGenerator now generates ImageConfiguration with g…
7aea29b 
…radle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
manusa pushed a commit that referenced this issue Oct 19, 2021
@rohanKanojia @manusa
Fix #850: SpringBootGenerator now generates ImageConfiguration with g…
b5960a5 
…radle

SpringBootGenerator generates ImageConfiguration when spring boot gradle
plugin is present in project

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@manusa manusa added this to the 1.5.0 milestone Nov 10, 2021
@manusa manusa mentioned this issue Dec 9, 2021
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
component/gradle-plugin Related to the Gradle Plugins
Projects
None yet
Milestone
1.5.0
Development

Successfully merging a pull request may close this issue.

Fix #850: SpringBootGenerator now generates ImageConfiguration with gradle rohanKanojia/jkube
2 participants
@manusa @rohanKanojia